Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44918: [Ruby] Fix a bug that empty list is ignored in builder #44933

Merged
merged 1 commit into from
Dec 9, 2024
+2 −2
Merged

GH-44918: [Ruby] Fix a bug that empty list is ignored in builder #44933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ruby/red-arrow/lib/arrow/list-array-builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def append_value(*args)
when nil
append_null
when ::Array
return if value.empty?
append_value_raw
return if value.empty?
@value_builder ||= value_builder
@value_builder.append(*value)
else
Expand Down
2 changes: 1 addition & 1 deletion ruby/red-arrow/test/test-list-array-builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def setup
builder = Arrow::ListArrayBuilder.new(data_type)
builder.append_value([])
array = builder.finish
assert_equal([], array[0].to_a)
assert_equal([[]], array.to_a)
end
end

Expand Down
Loading