-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44922: [MATLAB] Add IPC RecordBatchStreamFileWriter
MATLAB class
#44925
Conversation
…r and RecordBatchStreamWriter
Co-authored-by: Sutou Kouhei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Thanks, @sgilmore10!
Co-authored-by: Kevin Gurney <[email protected]>
Co-authored-by: Kevin Gurney <[email protected]>
Co-authored-by: Kevin Gurney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2b5a802. There were 132 benchmark results with an error:
There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 29 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
To enable support for the IPC Streaming format in the MATLAB interface, we should add a
RecordBatchStreamWriter
class.What changes are included in this PR?
Added
arrow.io.ipc.RecordBatchStreamWriter
class.Example Usage:
Are these changes tested?
Yes. I Parameterized the test cases in
test/arrow/io/ipc/tRecordBatchWriter.m
to test the behavior of botharrow.io.ipc.RecordBatchFileWriter
ANDarrow.io.ipc.RecordBatchStreamWriter
.Are there any user-facing changes?
Yes. Users can now use
arrow.io.ipc.RecordBatchStreamWriter
to serializeRecordBatch
es/Table
s to the Arrow IPC Streaming format.Future Directions
RecordBatchStreamReader
MATLAB class #44923RecordBatchStreamFileWriter
MATLAB class #44922