Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [R] Verify CRAN release-18.1.0-rc2 #44914

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions dev/tasks/r/github.recheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

{% import 'macros.jinja' as macros with context %}

{{ macros.github_header() }}

jobs:
recheck:
name: Reverse check {{ which }} dependents
uses: r-devel/recheck/.github/workflows/recheck.yml@9fe04de60ebeadd505b8d76223a346617ccca836
with:
which: {{ which }}
subdirectory: r
repository: {{ arrow.github_repo }}
ref: {{ arrow.branch }}
15 changes: 15 additions & 0 deletions dev/tasks/tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ groups:
r:
- test*-r-*
- r-binary-packages
- r-recheck-most

ruby:
- test-*ruby*
Expand Down Expand Up @@ -901,6 +902,20 @@ tasks:
- r-pkg__bin__macosx__big-sur-arm64__contrib__4.3__arrow_{no_rc_r_version}\.tgz
- r-pkg__src__contrib__arrow_{no_rc_r_version}\.tar\.gz

{% for which in ["strong", "most"] %}
# strong and most used here are defined by ?tools::package_dependencies as:
#
# strong: Depends, Imports, LinkingTo
# most: Depends, Imports, LinkingTo, Suggests
#
# So the key difference between strong and most is whether you want to expand
# the reverse dependency checking to Suggests (most) or not.
r-recheck-{{which}}:
ci: github
template: r/github.recheck.yml
params:
which: {{which}}
{% endfor %}

########################### Release verification ############################

Expand Down
9 changes: 9 additions & 0 deletions r/NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@

# arrow 18.1.0

## Minor improvements and fixes

* Fix bindings to allow filtering a factor column in a Dataset using `%in%` (#43446)
* Update `str_sub` binding to properly handle negative `end` values (@coussens, #44141)
* Fix altrep string columns from readr (#43351)
* Fix crash in ParquetFileWriter$WriteTable and add WriteBatch (#42241)
* Fix bindings in Math group generics (@aboyoun, #43162)
* Fix pull on a grouped query returns the wrong column (#43172)

# arrow 17.0.0

## New features
Expand Down
9 changes: 0 additions & 9 deletions r/README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
# arrow <img src="https://arrow.apache.org/img/arrow-logo_hex_black-txt_white-bg.png" align="right" alt="" width="120" />

<!-- badges: start -->

[![cran](https://www.r-pkg.org/badges/version-last-release/arrow)](https://cran.r-project.org/package=arrow)
[![CI](https://github.com/apache/arrow/workflows/R/badge.svg?event=push)](https://github.com/apache/arrow/actions?query=workflow%3AR+branch%3Amain+event%3Apush)
[![R-universe status badge](https://apache.r-universe.dev/badges/arrow)](https://apache.r-universe.dev)
[![conda-forge](https://img.shields.io/conda/vn/conda-forge/r-arrow.svg)](https://anaconda.org/conda-forge/r-arrow)

<!-- badges: end -->

## Overview

The R `{arrow}` package provides access to many of the features of the [Apache Arrow C++ library](https://arrow.apache.org/docs/cpp/index.html) for R users. The goal of arrow is to provide an Arrow C++ backend to `{dplyr}`, and access to the Arrow C++ library through familiar base R and tidyverse functions, or `{R6}` classes. The dedicated R package website is located [here](https://arrow.apache.org/docs/r/index.html).
Expand Down
2 changes: 1 addition & 1 deletion r/tools/update-checksums.R
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ for (path in binary_paths) {
if (grepl("windows", path)) {
cat(paste0("Converting ", path, " to windows style line endings\n"))
# UNIX style line endings cause errors with mysys2 sha512sum
sed_status <- system2("sed", args = c("-i", "s/\\\\r//", file))
sed_status <- system2("sed", args = c("-i", "-e", "s/\\\\r//", file))
if (sed_status != 0) {
stop("Failed to remove \\r from windows checksum file. Exit code: ", sed_status)
}
Expand Down
Loading