Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44711: [Docs][Python] Add missing canonical extension types to PyArrow arrays and datatypes docs #44880

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

msebbah
Copy link
Contributor

@msebbah msebbah commented Nov 28, 2024

Some of the canonical extension types which are implemented in PyArrow missing from the PyArrow arrays and datatypes docs pages have been added like JSON, UUID, Decimal256 and Bool8.

@kou
Copy link
Member

kou commented Nov 29, 2024

@github-actions crossbow submit preview-docs

Copy link

Revision: 172e98c

Submitted crossbow builds: ursacomputing/crossbow @ actions-14d6423697

Task Status
preview-docs GitHub Actions

@kou
Copy link
Member

kou commented Nov 29, 2024

I confirmed that all added changes are reflected in documents but I haven't checked whether the added changes cover all missing items... @ianmcook Could you review the change?

@msebbah Could you use our PR template instead of removing it entirely next time?

@ianmcook
Copy link
Member

Thanks for doing this @msebbah. This looks good to me except for the order of the new entries. See my comments above about that.

I confirmed that all added changes are reflected in documents but I haven't checked whether the added changes cover all missing items... @ianmcook Could you review the change?

@kou This covers all the missing items that I was able to identify during 30+ minutes of searching.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Nov 29, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 29, 2024
@ianmcook
Copy link
Member

@github-actions crossbow submit preview-docs

Copy link

Revision: 73b5813

Submitted crossbow builds: ursacomputing/crossbow @ actions-df9fb0630d

Task Status
preview-docs GitHub Actions

@ianmcook
Copy link
Member

@github-actions crossbow submit preview-docs

Copy link

Revision: 73b5813

Submitted crossbow builds: ursacomputing/crossbow @ actions-08189ee106

Task Status
preview-docs GitHub Actions

@ianmcook
Copy link
Member

In the Scalars section of arrays.rst, I just noticed that some things are missing:

  • NullScalar
  • Decimal256Scalar
  • FixedSizeListScalar
  • JsonScalar
  • UuidScalar
  • Bool8Scalar

These all appear in https://github.com/apache/arrow/blob/main/python/pyarrow/scalar.pxi but are missing here.

@msebbah could you please add these, in roughly the same order as they appear in various other lists? Thanks!

@msebbah
Copy link
Contributor Author

msebbah commented Dec 8, 2024

Hi @ianmcook, it should be better now, could you review the PR, please ?

@kou
Copy link
Member

kou commented Dec 9, 2024

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Dec 9, 2024

Revision: 27f6d23

Submitted crossbow builds: ursacomputing/crossbow @ actions-f0f92dea49

Task Status
preview-docs GitHub Actions

@ianmcook ianmcook merged commit 5207f1e into apache:main Dec 9, 2024
6 checks passed
@ianmcook
Copy link
Member

ianmcook commented Dec 9, 2024

Thanks @msebbah!

Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5207f1e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants