-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44802: [C++][CI] Migrate to arrow::Result
based parquet::arrow::OpenFile() API
in example tutorials
#44807
GH-44802: [C++][CI] Migrate to arrow::Result
based parquet::arrow::OpenFile() API
in example tutorials
#44807
Conversation
|
arrow::Result
based parquet::arrow::OpenFile() API
in example tutorials
@github-actions crossbow submit example-cpp-tutorial |
Revision: 8acc696 Submitted crossbow builds: ursacomputing/crossbow @ actions-08ec77adbe
|
Co-authored-by: Sutou Kouhei <[email protected]>
@kou Thanks for your feedback and review. I have committed your suggested changes. Please let me know if there are any other suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ae497bf. There were 132 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This PR address this issue and updates the
example-cpp-tutorial
in Crossbow to resolve build failures caused by deprecated APIs, as seen in this CI job. The change migrates the examples to non-deprecated APIs to ensure compatibility with the latest Arrow C++ version.Updating these APIs is necessary to:
Fix build failures and prevent future issues.
Align with the current Arrow C++ API.
What changes are included in this PR?
This PR updates the example-cpp-tutorial to replace deprecated Arrow C++ APIs with the latest supported APIs, resolving build failures in the Crossbow night build.
Are these changes tested?
By running:
output:
Are there any user-facing changes?
Yes, the tutorial has been updated to use non-deprecated APIs, which may affect the example code provided to users.