GH-44742: [Ruby] Fix a bug that empty struct list value can't be built #44763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 66c2cf0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
kou
added a commit
that referenced
this pull request
Dec 9, 2024
) ### Rationale for this change `Arrow::ListArrayBuilder#append_value` with `[]` must append an empty list as an element. In general, it works but it doesn't work when list item is struct or list. Because `Arrow::{List,Struct}ArrayBuilder#append` without arguments appends an element. It's for a backward compatibility. But it has a problem for this case. For example, the following case has this problem: ```ruby item_type = Arrow::StructDataType.new([{name: "visible", type: :boolean}]) data_type = Arrow::ListDataType.new(name: "struct", data_type: item_type) builder = Arrow::ListArrayBuilder.new(data_type) builder.append_value([]) array = builder.finish array.to_a # => must be [[]] but [] without this change ``` ### What changes are included in this PR? This should be fixed by GH-44763 but the fix was wrong. This change fixes wrong `return if` location. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #44918 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This codes add a list value but no struct value isn't added:
What changes are included in this PR?
Don't add a list value.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.