Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running #44584

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running #44584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6a9495
Check if process_thread_ is running before attempting to join
mroz45 Oct 30, 2024
e858e4f
Fixed format
mroz45 Oct 30, 2024
8572038
Test with invalid plan
mroz45 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/src/arrow/acero/asof_join_node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,9 @@ class AsofJoinNode : public ExecNode {
virtual ~AsofJoinNode() {
#ifdef ARROW_ENABLE_THREADING
PushProcess(false);
process_thread_.join();
if (process_thread_.joinable()) {
process_thread_.join();
}
#endif
}

Expand Down
27 changes: 27 additions & 0 deletions cpp/src/arrow/acero/asof_join_node_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,6 +1731,33 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
ExecBatchFromJSON({int64(), utf8()}, R"([[1, "Z"], [2, "Z"], [3, "B"]])");
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing

// a sink that fails on creation
TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
auto left_batch = ExecBatchFromJSON({int64()}, R"([[1], [2], [3]])");
auto right_batch =
ExecBatchFromJSON({utf8(), int64()}, R"([["Z", 2], ["B", 3], ["A", 4]])");

Declaration left{"exec_batch_source",
ExecBatchSourceNodeOptions(schema({field("on", int64())}),
{std::move(left_batch)})};
Declaration right{
"exec_batch_source",
ExecBatchSourceNodeOptions(schema({field("colVals", utf8()), field("on", int64())}),
{std::move(right_batch)})};
AsofJoinNodeOptions asof_join_opts({{{"on"}, {}}, {{"on"}, {}}}, 1);
Declaration asof_join{
"asofjoin", {std::move(left), std::move(right)}, std::move(asof_join_opts)};

arrow::acero::SinkNodeOptions sink_node_options{nullptr, nullptr};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add: 1) parameter name (e.g. /*xxx=*/nullptr, /*xxx=*/nullptr), 2) some comments about how this intentionally invalid nullptr is essential for the reproduction of the targeting bug?

arrow::acero::Declaration sink =
arrow::acero::Declaration::Sequence({asof_join, {"sink", sink_node_options}});

EXPECT_RAISES_WITH_MESSAGE_THAT(
Invalid,
::testing::HasSubstr(
"`generator` is a required SinkNode option and cannot be null"),
DeclarationToStatus(std::move(sink)));
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

} // namespace acero
} // namespace arrow
Loading