-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [R] Verify CRAN release-18.0.0-rc0 #44523
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit -g r |
Revision: f96684f Submitted crossbow builds: ursacomputing/crossbow @ actions-f88c4a573f |
@github-actions crossbow submit r-recheck-* |
### Rationale for this change The referenced change was included in the 17.0.0.1 CRAN submission (#43317 (comment)) so we don't need to announce it here. As far as CRAN releases go, the performance regression was never released. ### What changes are included in this PR? rm ### Are these changes tested? 🙅 ### Are there any user-facing changes? Words
@github-actions crossbow submit -g r |
Revision: 5a57166 Submitted crossbow builds: ursacomputing/crossbow @ actions-b60b8e8d5c |
Crossbow jobs are looking better now but |
@github-actions crossbow submit r-recheck-* |
Revision: 0230d89 Submitted crossbow builds: ursacomputing/crossbow @ actions-e6d1ebfdb9
|
On the thrift timeout, I just tried each of the URLs that are listed in the logs and while the first one did work for me right now, all the rest 404ed. Which makes me think that something might be wrong with those URLs and we should update them so that we have backups again:
|
Oh, you're right. I think only the closer.cgi one works for me. I'll look into that. |
Some observations:
https://apache.org/history/mirror-history.html gives more context and this sentence may explain why this list of URLs degraded over time:
So I think by continuing to use these mirror URLs we were living on borrowed time. The CDN is now the recommended way for users to download content from ASF projects. So I think we actually need to do two things here:
|
We also use https://archive.apache.org/dist/thrift/ which has older versions (including 0.16.0), though I'm not sure if using it is appropriate. |
@amoeba yes we can use archive.a.o if we need an older version but imo if a newer version works we should update, I will create a blocker issue for 18.0.1 |
Thanks @assignUser! |
…ies on GHA (#43784) ### Rationale for this change See #43547. ### What changes are included in this PR? Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: - `r-recheck-most` - `r-recheck-strong` ### Are these changes tested? Yes. #44523 (comment). ### Are there any user-facing changes? No. * GitHub Issue: #43547 Fixes #43547. Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
Closing as we're done with this PR now. See #44496 for context. |
…ies on GHA (#43784) ### Rationale for this change See #43547. ### What changes are included in this PR? Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: - `r-recheck-most` - `r-recheck-strong` ### Are these changes tested? Yes. #44523 (comment). ### Are there any user-facing changes? No. * GitHub Issue: #43547 Fixes #43547. Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
Only using this to trigger crossbow jobs for the CRAN release. Do not merge.