Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [R] Verify CRAN release-18.0.0-rc0 #44523

Closed
wants to merge 7 commits into from
Closed

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Oct 24, 2024

Only using this to trigger crossbow jobs for the CRAN release. Do not merge.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@amoeba
Copy link
Member Author

amoeba commented Oct 24, 2024

@github-actions crossbow submit -g r

Copy link

Revision: f96684f

Submitted crossbow builds: ursacomputing/crossbow @ actions-f88c4a573f

Task Status
r-binary-packages GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Oct 24, 2024

@github-actions crossbow submit r-recheck-*

### Rationale for this change

The referenced change was included in the 17.0.0.1 CRAN submission
(#43317 (comment))
so we don't need to announce it here. As far as CRAN releases go, the
performance regression was never released.

### What changes are included in this PR?

rm

### Are these changes tested?

🙅 

### Are there any user-facing changes?

Words
@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

@github-actions crossbow submit -g r

Copy link

Revision: 5a57166

Submitted crossbow builds: ursacomputing/crossbow @ actions-b60b8e8d5c

Task Status
r-binary-packages GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

Crossbow jobs are looking better now but test-r-linux-as-cran is failing on what appears to be downloading Thrift. I took a look at the logs and it looks like it's trying a few mirrors, failing on each, and not trying the rest? According to the cmake docs, all of them should get tried. @assignUser do you have any ideas?

@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

@github-actions crossbow submit r-recheck-*

Copy link

Revision: 0230d89

Submitted crossbow builds: ursacomputing/crossbow @ actions-e6d1ebfdb9

Task Status
r-recheck-most GitHub Actions
r-recheck-strong GitHub Actions

@jonkeane
Copy link
Member

On the thrift timeout, I just tried each of the URLs that are listed in the logs and while the first one did work for me right now, all the rest 404ed. Which makes me think that something might be wrong with those URLs and we should update them so that we have backups again:

-- Downloading...
   dst='/tmp/RtmpAwPrlt/working_dir/RtmpBltHq0/file743780f417a/thrift_ep-prefix/src/thrift-0.16.0.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://www.apache.org/dyn/closer.cgi?action=download&filename=/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://downloads.apache.org/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.claz.org/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.cs.utah.edu/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.mirrors.lucidnetworks.net/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.osuosl.org/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- [download 0% complete]
-- Using src='https://apache.cs.utah.edu/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.mirrors.lucidnetworks.net/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://ftp.wayne.edu/apache/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- [download 0% complete]
-- Using src='https://apache.cs.utah.edu/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://apache.mirrors.lucidnetworks.net/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://mirror.olnevhost.net/pub/apache/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- [download 0% complete]

@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

Oh, you're right. I think only the closer.cgi one works for me. I'll look into that.

@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

Some observations:

  • downloads.apache.org only has archives of Thrift 0.20.0 and 0.21.0 (current latest stable is 0.21.0)
  • Apache appears to now (since 2021?) have a CDN: https://dlcdn.apache.org/thrift/. That also only has archives of 0.20.0 and 0.21.0.

https://apache.org/history/mirror-history.html gives more context and this sentence may explain why this list of URLs degraded over time:

Any organization that has been hosting an Apache download mirror site, and that finds it useful for its own purposes, may continue to host the mirror site.

So I think by continuing to use these mirror URLs we were living on borrowed time. The CDN is now the recommended way for users to download content from ASF projects.

So I think we actually need to do two things here:

  • Change the URL to just use the ASF CDN
  • Update our Thrift version in cpp/thirdparty/versions.txt to 0.20.0 or greater. Arrow C++ builds cleanly on my system when using Brew-provided Thrift 0.21.0 so it seems like this may be doable.

@amoeba
Copy link
Member Author

amoeba commented Oct 31, 2024

We also use https://archive.apache.org/dist/thrift/ which has older versions (including 0.16.0), though I'm not sure if using it is appropriate.

@assignUser
Copy link
Member

@amoeba yes we can use archive.a.o if we need an older version but imo if a newer version works we should update, I will create a blocker issue for 18.0.1

@amoeba
Copy link
Member Author

amoeba commented Nov 1, 2024

Thanks @assignUser!

amoeba added a commit that referenced this pull request Nov 1, 2024
…ies on GHA (#43784)

### Rationale for this change

See #43547.

### What changes are included in this PR?

Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: 

- `r-recheck-most` 
- `r-recheck-strong`

### Are these changes tested?

Yes. #44523 (comment).

### Are there any user-facing changes?

No.
* GitHub Issue: #43547

Fixes #43547.

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
@amoeba
Copy link
Member Author

amoeba commented Nov 5, 2024

Closing as we're done with this PR now. See #44496 for context.

@amoeba amoeba closed this Nov 5, 2024
amoeba added a commit that referenced this pull request Dec 3, 2024
…ies on GHA (#43784)

### Rationale for this change

See #43547.

### What changes are included in this PR?

Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: 

- `r-recheck-most` 
- `r-recheck-strong`

### Are these changes tested?

Yes. #44523 (comment).

### Are there any user-facing changes?

No.
* GitHub Issue: #43547

Fixes #43547.

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants