-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44448: [C++] Add support for overwriting grpc_cpp_plugin path for cross-compiling #44507
Conversation
… for cross-compiling
|
Thanks a lot for the quick PR! It would be really nice if we could also change this where it's invoked, i.e. arrow/cpp/src/arrow/flight/CMakeLists.txt Lines 95 to 98 in 5ea3aa1
Currently our builds scripts are doing sed -ie "s;protoc-gen-grpc.*$;protoc-gen-grpc=${BUILD_PREFIX}/bin/grpc_cpp_plugin\";g" ../src/arrow/flight/CMakeLists.txt to work around this... |
This will work for the case because this overwrites |
Confirmed in conda-forge/arrow-cpp-feedstock#1432 that this works, even without the |
Thanks for confirming this. I'll merge this. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8eccbfe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…cross-compiling (#44507) ### Rationale for this change We can't use `find_package(gRPC)` and `gRPC::grpc_cpp_plugin` for cross-compiling because it's for host. We need `grpc_cpp_plugin` for target in cross-compiling. ### What changes are included in this PR? Add `ARROW_GRPC_CPP_PLUGIN` CMake option that overwrites `gRPC::grpc_cpp_plugin` path found by `find_package(gRPC)`. ### Are these changes tested? Yes. conda-forge/arrow-cpp-feedstock#1432 ### Are there any user-facing changes? Yes. * GitHub Issue: #44448 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
We can't use
find_package(gRPC)
andgRPC::grpc_cpp_plugin
for cross-compiling because it's for host. We needgrpc_cpp_plugin
for target in cross-compiling.What changes are included in this PR?
Add
ARROW_GRPC_CPP_PLUGIN
CMake option that overwritesgRPC::grpc_cpp_plugin
path found byfind_package(gRPC)
.Are these changes tested?
Yes.
conda-forge/arrow-cpp-feedstock#1432
Are there any user-facing changes?
Yes.
<nmmintrin.h>
resp. mis-detection ofgrpc_cpp_plugin
#44448