GH-44432: [Swift] Use flatbuffers v24.3.7 #44433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Swift
awaiting committer review
kou
changed the title
|
@abandy What do you think about this? |
Makes sense to pin the version to prevent potential errors from changes in master. Good idea, thank you! |
|
Thanks for your review. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bb900c1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
amoeba
pushed a commit
that referenced
this pull request
Nov 13, 2024
### Rationale for this change flatbuffers v24.3.7 includes google/flatbuffers#8134 . The current master has a build error: https://github.com/apache/arrow/actions/runs/11357784776/job/31591213976?pr=44431#step:5:1114 ```text [51/77] Compiling Arrow ArrowType.swift /arrow/swift/Arrow/Sources/Arrow/File_generated.swift:107:206: error: value of type 'Table' has no member 'postion' public var schema: org_apache_arrow_flatbuf_Schema? { let o = _accessor.offset(VTOFFSET.schema.v); return o == 0 ? nil : org_apache_arrow_flatbuf_Schema(_accessor.bb, o: _accessor.indirect(o + _accessor.postion)) } ~~~~~~~~~ ^~~~~~~ ``` ### What changes are included in this PR? Use v24.3.7 instead of master. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #44432 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
flatbuffers v24.3.7 includes google/flatbuffers#8134 .
The current master has a build error:
https://github.com/apache/arrow/actions/runs/11357784776/job/31591213976?pr=44431#step:5:1114
What changes are included in this PR?
Use v24.3.7 instead of master.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.