GH-44268: [Release][Ruby][CI] Pin version of glib used in verification script #44270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the issue reported in apache#44268.
amoeba
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
amoeba
changed the title
|
|
|
@github-actions crossbow submit verify-rc-source-ruby-linux-conda-latest-amd64 |
|
Revision: 1f52672 Submitted crossbow builds: ursacomputing/crossbow @ actions-182050b084
|
github-actions
bot
added
awaiting merge
Co-authored-by: Sutou Kouhei <[email protected]>
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit de9462d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Oct 14, 2024
Merged
amoeba
added a commit
that referenced
this pull request
Oct 15, 2024
…rification script (#44407) ### Rationale for this change We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268. ### What changes are included in this PR? Tweaks to release release verification script, specifically removing recently-added pins. ### Are these changes tested? Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285. ### Are there any user-facing changes? No. Closes #44415. * GitHub Issue: #44415 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
Oct 15, 2024
…rification script (#44407) ### Rationale for this change We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268. ### What changes are included in this PR? Tweaks to release release verification script, specifically removing recently-added pins. ### Are these changes tested? Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285. ### Are there any user-facing changes? No. Closes #44415. * GitHub Issue: #44415 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes failing verification task for ruby+conda, see #44268. cc @raulcd
What changes are included in this PR?
It looks like the proximate cause of the failure was a buggy release of glib (2.82.1) on conda-forge, see conda-forge/glib-feedstock#191. Pinning the version of glib we install inside the verification script to the previous version seems to work (verification passes locally now). Once the glib feedstock pushes a new release with the fix we can unpin this.
Are these changes tested?
Yes, locally under docker.
Are there any user-facing changes?
No.