-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44222: [C++][Gandiva] Accept LLVM 19.1 #44233
Conversation
@github-actions crossbow submit -g cpp |
|
Revision: 96be329 Submitted crossbow builds: ursacomputing/crossbow @ actions-b5508a5d51 |
@github-actions crossbow submit java-jars |
Revision: 96be329 Submitted crossbow builds: ursacomputing/crossbow @ actions-88a671c085
|
+1 AppVeyor failure is #44234. |
@kou I recently disabled some tests in Gandiva because of the issue mentioned here apache/arrow-java#55 Do you think re-enabling and testing would be a feasible idea with this change? cc @lidavidm |
Let's just leave it IMO, I hope the Gandiva maintainers can step back up to reenable the tests |
We can work on re-enabling them as a separated PR. I'll merge this. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3505457. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
LLVM 19.1.0 was released.
What changes are included in this PR?
Accept LLVM 19.1.0.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.