GH-44011: [Java] Consider warnings as errors for C Module #44012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhatha
force-pushed
the
feat-errorprone-warning-c
branch
from
ce8a33f
to
dda3b5a
Compare
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Sep 10, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 09ed5e5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 33 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…he#44012) ### Rationale for this change This PR configs the build such that warnings are considered as errors in the C module. And corresponding code changes have also been made. ### What changes are included in this PR? Adding flags to consider warnings as errors in javac and fixing the corresponding errors. ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? N/A * GitHub Issue: apache#44011 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
zeroshade
pushed a commit
to zeroshade/arrow
that referenced
this pull request
Sep 30, 2024
…he#44012) ### Rationale for this change This PR configs the build such that warnings are considered as errors in the C module. And corresponding code changes have also been made. ### What changes are included in this PR? Adding flags to consider warnings as errors in javac and fixing the corresponding errors. ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? N/A * GitHub Issue: apache#44011 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR configs the build such that warnings are considered as errors in the C module. And corresponding code changes have also been made.
What changes are included in this PR?
Adding flags to consider warnings as errors in javac and fixing the corresponding errors.
Are these changes tested?
Tested by existing test cases.
Are there any user-facing changes?
N/A