GH-43996: [Java] Mark new allocated ArrowSchema as released #43997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
|
|
github-actions
bot
added
awaiting merge
Sure. I was looking for an existing test file to add test for it, but didn't find one for ArrowArray/ArrowSchema. I will find one or create a new one instead. Thank you. |
github-actions
bot
added
Component: Java
awaiting change review
viirya
commented
Sep 9, 2024
java/c/src/test/java/org/apache/arrow/c/ArrowArrayUtilityTest.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting changes
viirya
force-pushed
the
init_arrow_schema
branch
from
2a68db2 to
82d0f49
Compare
github-actions
bot
added
awaiting change review
|
Compilation issue? |
viirya
force-pushed
the
init_arrow_schema
branch
from
82d0f49 to
85e729d
Compare
viirya
force-pushed
the
init_arrow_schema
branch
from
85e729d to
d3df8e9
Compare
Yea, fixed it now. I cannot run the test locally so previous commits have some issues. |
lidavidm
approved these changes
Sep 10, 2024
lidavidm
changed the title
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fed5fcb. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 115 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
Thanks @lidavidm |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…ache#43997) ### Rationale for this change As described in apache#43996. ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * GitHub Issue: apache#43996 Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: David Li <[email protected]>
zeroshade
pushed a commit
to zeroshade/arrow
that referenced
this pull request
Sep 30, 2024
…ache#43997) ### Rationale for this change As described in apache#43996. ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * GitHub Issue: apache#43996 Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As described in #43996.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?