Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40216: [Python][CI][Packaging] Don't upload sdist to scientific-python nightly channel (only wheels) #43943

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 4, 2024

Rationale for this change

See #40216 (comment) for context. It might be expected that the channel only holds wheels, to users (downstream projects' CI) would accidentally try build from the sdist (e.g. when a wheel is missing).

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 4, 2024
@jorisvandenbossche jorisvandenbossche changed the title GH-40216: [Pytohn][CI][Packaging] Don't upload sdist to scientific-python nightly channel (only wheels) GH-40216: [Python][CI][Packaging] Don't upload sdist to scientific-python nightly channel (only wheels) Sep 4, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following this up @jorisvandenbossche

@raulcd raulcd merged commit 9445fe4 into apache:main Sep 4, 2024
8 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Sep 4, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Sep 4, 2024
@jorisvandenbossche jorisvandenbossche deleted the gh-40216-no-sdist-upload branch September 4, 2024 08:52
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9445fe4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Sep 6, 2024
…fic-python nightly channel (only wheels) (apache#43943)

### Rationale for this change

See apache#40216 (comment) for context. It might be expected that the channel only holds wheels, to users (downstream projects' CI) would accidentally try build from the sdist (e.g. when a wheel is missing).

* GitHub Issue: apache#40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…fic-python nightly channel (only wheels) (apache#43943)

### Rationale for this change

See apache#40216 (comment) for context. It might be expected that the channel only holds wheels, to users (downstream projects' CI) would accidentally try build from the sdist (e.g. when a wheel is missing).

* GitHub Issue: apache#40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants