Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43933: [CI] Remove docker-compose warnings #43934

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Sep 3, 2024

Rationale for this change

Remove docker-compose warnings to avoid confusion when running docker-compose and see them appear at the top. The two warnings are about:

  • PYTHON_IMAGE_TAG not having a default value in .env
  • version in docker-compose.yml is obsolete and should be removed.

What changes are included in this PR?

  • Add a PYTHON_IMAGE_TAG default value in .env
  • Remove version from docker-compose.yml

Are these changes tested?

Yes, the warnings are removed with these changes.

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Sep 3, 2024

⚠️ GitHub issue #43933 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 3, 2024
@raulcd
Copy link
Member

raulcd commented Sep 3, 2024

@github-actions crossbow submit test-cuda-*

@raulcd
Copy link
Member

raulcd commented Sep 3, 2024

Thanks for the PR!
The only runner images that haven't been updated to the latest docker-compose versions are the cuda runners (there is currently some effort to do so). I am just validating the jobs doesn't fail for those when removing the version from the docker-compose.yml file. If the jobs are successful I am happy to merge!

Copy link

github-actions bot commented Sep 3, 2024

Revision: 7ff037a

Submitted crossbow builds: ursacomputing/crossbow @ actions-932da7be5a

Task Status
test-cuda-cpp GitHub Actions
test-cuda-python GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raulcd raulcd merged commit c455d6b into apache:main Sep 3, 2024
61 of 62 checks passed
@raulcd raulcd removed the awaiting review Awaiting review label Sep 3, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Sep 3, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c455d6b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Sep 6, 2024
### Rationale for this change

Remove `docker-compose` warnings to avoid confusion when running `docker-compose` and see them appear at the top. The two warnings are about:

- `PYTHON_IMAGE_TAG` not having a default value in `.env`
- `version` in `docker-compose.yml` is obsolete and should be removed.

### What changes are included in this PR?

- Add a `PYTHON_IMAGE_TAG` default value in `.env`
- Remove `version` from `docker-compose.yml`

### Are these changes tested?

Yes, the warnings are removed with these changes.

### Are there any user-facing changes?
 No.

* GitHub Issue: apache#43933

Authored-by: Lysandros Nikolaou <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
### Rationale for this change

Remove `docker-compose` warnings to avoid confusion when running `docker-compose` and see them appear at the top. The two warnings are about:

- `PYTHON_IMAGE_TAG` not having a default value in `.env`
- `version` in `docker-compose.yml` is obsolete and should be removed.

### What changes are included in this PR?

- Add a `PYTHON_IMAGE_TAG` default value in `.env`
- Remove `version` from `docker-compose.yml`

### Are these changes tested?

Yes, the warnings are removed with these changes.

### Are there any user-facing changes?
 No.

* GitHub Issue: apache#43933

Authored-by: Lysandros Nikolaou <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants