-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43933: [CI] Remove docker-compose warnings #43934
Conversation
|
@github-actions crossbow submit test-cuda-* |
Thanks for the PR! |
Revision: 7ff037a Submitted crossbow builds: ursacomputing/crossbow @ actions-932da7be5a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c455d6b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Remove `docker-compose` warnings to avoid confusion when running `docker-compose` and see them appear at the top. The two warnings are about: - `PYTHON_IMAGE_TAG` not having a default value in `.env` - `version` in `docker-compose.yml` is obsolete and should be removed. ### What changes are included in this PR? - Add a `PYTHON_IMAGE_TAG` default value in `.env` - Remove `version` from `docker-compose.yml` ### Are these changes tested? Yes, the warnings are removed with these changes. ### Are there any user-facing changes? No. * GitHub Issue: apache#43933 Authored-by: Lysandros Nikolaou <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
### Rationale for this change Remove `docker-compose` warnings to avoid confusion when running `docker-compose` and see them appear at the top. The two warnings are about: - `PYTHON_IMAGE_TAG` not having a default value in `.env` - `version` in `docker-compose.yml` is obsolete and should be removed. ### What changes are included in this PR? - Add a `PYTHON_IMAGE_TAG` default value in `.env` - Remove `version` from `docker-compose.yml` ### Are these changes tested? Yes, the warnings are removed with these changes. ### Are there any user-facing changes? No. * GitHub Issue: apache#43933 Authored-by: Lysandros Nikolaou <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
Remove
docker-compose
warnings to avoid confusion when runningdocker-compose
and see them appear at the top. The two warnings are about:PYTHON_IMAGE_TAG
not having a default value in.env
version
indocker-compose.yml
is obsolete and should be removed.What changes are included in this PR?
PYTHON_IMAGE_TAG
default value in.env
version
fromdocker-compose.yml
Are these changes tested?
Yes, the warnings are removed with these changes.
Are there any user-facing changes?
No.