GH-43635: [R][CI] Don't install Quarto #43636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @amoeba too |
|
I'm going to merge this to stop the ❌ on main. But am very open to suggestions / updates post hoc. |
|
Thanks for the fix and infra ticket @jonkeane! I think this is fine for now, once the infra ticket is solved we can move forward. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ee86db5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
pitrou
pushed a commit
that referenced
this pull request
Aug 22, 2024
Undo the pinning in #43636 now that INFRA has approved the quarto-dev action Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Sep 3, 2024
…che#43730) Undo the pinning in apache#43636 now that INFRA has approved the quarto-dev action Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin to an old version of r-lib/actions that does not reference quarto-dev/quarto-actions. Though we still want to ask INFRA to add quarto-dev to the approved list.