Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Documentation] Add installation of ninja-build to Python Development docs #43600

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

albertvillanova
Copy link
Contributor

@albertvillanova albertvillanova commented Aug 7, 2024

Rationale for this change

Otherwise, you get a CMake error:

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Given the instructions after that explicitly use ninja, it indeed seems best to include that (although not strictly required)

@jorisvandenbossche jorisvandenbossche merged commit cc3c868 into apache:main Aug 20, 2024
9 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting review Awaiting review label Aug 20, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 20, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cc3c868.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants