GH-43479: [Java] Change visibility of MemoryUtil.UNSAFE #43480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MemoryUtil.UNSAFE` field is a public field which provides unrestricted access to `sun.misc.Unsafe` instance which may cause misusage and possibly JVM crashes. Make the field private and only allow indirect use of Unsafe through `MemoryUtil` methods
|
|
lidavidm
approved these changes
Jul 30, 2024
|
@github-actions crossbow submit -g java |
github-actions
bot
added
awaiting merge
|
Revision: fa8ebde Submitted crossbow builds: ursacomputing/crossbow @ actions-75ecf561e7
|
vibhatha
approved these changes
Jul 30, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6bba203. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
MemoryUtil.UNSAFEfield is a public field which provides unrestricted access tosun.misc.Unsafeinstance which may cause misusage and possibly JVM crashes.What changes are included in this PR?
Make the field (and other related fields) private and only allow indirect use of Unsafe through
MemoryUtilmethodsAre these changes tested?
Yes.
Are there any user-facing changes?
No
This PR includes breaking changes to public APIs.
Code using
MemoryUtil.UNSAFEwould break as the visibility of the field was changed to privatesun.misc.Unsafe#43479