GH-43377: [Java][CI] Java-Jars CI is Failing with a linking error on macOS #43385
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,7 +83,7 @@ jobs: | |
| - { runs_on: ["macos-13"], arch: "x86_64"} | ||
| - { runs_on: ["macos-14"], arch: "aarch_64" } | ||
| env: | ||
| MACOSX_DEPLOYMENT_TARGET: "14.0" | ||
| steps: | ||
| {{ macros.github_checkout_arrow()|indent }} | ||
| - name: Set up Python | ||
|
|
@@ -140,6 +140,12 @@ jobs: | |
| brew uninstall protobuf | ||
|
|
||
| brew bundle --file=arrow/java/Brewfile | ||
|
|
||
| # We want to use the bundled googletest for static linking. Since | ||
| # both BUNDLED and brew options are enabled, it could cause a conflict | ||
| # when there is a version mismatch. | ||
| # We uninstall googletest to ensure using the bundled googletest. | ||
| brew uninstall googletest | ||
|
Comment on lines
+143
to
+148
There was a problem hiding this comment. Could you move this part before There was a problem hiding this comment. Sure @kou I will make a follow up PR shortly. |
||
| - name: Build C++ libraries | ||
| env: | ||
| {{ macros.github_set_sccache_envvars()|indent(8) }} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vibhatha That's quite the bump, I am pretty sure we also want to support less recent macos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad for merging this quickly. I was too eager to get java-jars working again. Let's revert that part of the diff since it's not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worry, it's a good goal^^ We can likely bump it to 11 or even 12 (as 11 is also eol... but we don't have a support policy so...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@assignUser this was an artifact from my previous failed attempt to fix this issue. I have not reverted that. But I will revert it shortly.