GH-41470: [C++] Reuse deduplication logic for direct registration

[bkietz]

Rationale for this change

As observed in #41309 a crossbow job on mac is failing due to duplicate registration of a factory for the file:// scheme

What changes are included in this PR?

Deduplication of registered filesystem factories is applied to direct registration as well as when merging registries.

Are these changes tested?

No, we just need to verify that the problematic crossbow job is repaired.

Are there any user-facing changes?

No

• GitHub Issue: [C++] Spurious duplicate registration of file:// factory #41470

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[bkietz]

@github-actions crossbow submit -g homebrew

[github-actions]

Revision: e798267

Submitted crossbow builds: ursacomputing/crossbow @ actions-05f8f5ff1f

Task	Status
homebrew-cpp

[vibhatha]

@github-actions crossbow submit java

[bkietz]

@github-actions crossbow submit -g java-jars

[github-actions]

Invalid group(s) {'java-jars'}. Must be one of {'homebrew', 'verify-rc-wheels', 'conda', 'c-glib', 'verify-rc-source', 'ruby', 'integration', 'wheel', 'fuzz', 'nightly-packaging', 'linux-arm64', 'java', 'vcpkg', 'test', 'verify-rc-source-macos', 'verify-rc-jars', 'packaging', 'nightly-release', 'linux-amd64', 'example-python', 'verify-rc-source-linux', 'go', 'linux', 'verify-rc', 'nightly-tests', 'nightly', 'conan', 'example', 'example-cpp', 'r', 'cpp', 'python', 'verify-rc-binaries'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8897392124

[github-actions]

Revision: e798267

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c4f4373f4

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

[lidavidm]

@github-actions crossbow submit java-jars

[lidavidm]

macos-latest == macos-14 now so if we want amd64 we have to explicitly request macos-13

[github-actions]

Revision: 2fd3fcc

Submitted crossbow builds: ursacomputing/crossbow @ actions-319edba519

Task	Status
java-jars

[bkietz]

The error doesn't seem related to filesystem anymore: https://github.com/ursacomputing/crossbow/actions/runs/8903205653/job/24451424677#step:6:16247

I'm not sure what it means though

[vibhatha]

@lidavidm this seems to be from the recent maven build update?

[lidavidm]

We can merge this regardless and @vibhatha can file a new ticket.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14c54bb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.

[raulcd]

I will have to manually include: 2fd3fcc into 16.1.0 in order to have a passing java-jars job as we don't want to add the other commits of this PR (the filesystems split should go into 17.0.0 instead of 16.1.0)
I plan to add the above as a manual commit along with the fix for: #41578