Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java] Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18 #41458

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Apr 30, 2024

Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

What changes are included in this PR?

  • Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18

Are these changes tested?

  • yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@lidavidm lidavidm changed the title MINOR[Java]Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18 MINOR: [Java] Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18 Apr 30, 2024
@lidavidm
Copy link
Member

@github-actions crossbow submit -g java

Copy link

Revision: 977b1d9

Submitted crossbow builds: ursacomputing/crossbow @ actions-40e44a3ef5

Task Status
java-jars GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@lidavidm lidavidm merged commit 97e169a into apache:main Apr 30, 2024
17 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Apr 30, 2024
@CalvinKirs CalvinKirs deleted the main-bcpkix-jdk branch April 30, 2024 10:18
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 97e169a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…ache#41458)

### Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

### What changes are included in this PR?

- Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18
### Are these changes tested?

- yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Authored-by: Calvin Kirs <[email protected]>
Signed-off-by: David Li <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 4, 2024
…ache#41458)

### Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

### What changes are included in this PR?

- Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18
### Are these changes tested?

- yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Authored-by: Calvin Kirs <[email protected]>
Signed-off-by: David Li <[email protected]>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…ache#41458)

### Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

### What changes are included in this PR?

- Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18
### Are these changes tested?

- yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Authored-by: Calvin Kirs <[email protected]>
Signed-off-by: David Li <[email protected]>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…ache#41458)

### Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

### What changes are included in this PR?

- Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18
### Are these changes tested?

- yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Authored-by: Calvin Kirs <[email protected]>
Signed-off-by: David Li <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ache#41458)

### Rationale for this change

Since bcpkix-jdk15on is no longer being maintained and bcpkix-jdkon18 is fully compatible with it, we can replace bcpkix-jdk15on with bcpkix-jdkon18. This will ensure continued support and security for our applications.
FYI: https://www.bouncycastle.org/latest_releases.html

### What changes are included in this PR?

- Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18
### Are these changes tested?

- yes

We used the JcaPEMWriter class to convert certificates stored within a KeyStore object into PEM format and subsequently write them to a designated JcaPEMWriter object. Existing test suites provide comprehensive coverage for this functionality.

Authored-by: Calvin Kirs <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants