Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same result on x86 and Arm #41434

Merged
merged 1 commit into from
Apr 30, 2024
Merged

GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same result on x86 and Arm #41434

merged 1 commit into from
Apr 30, 2024

Conversation

DenisTarasyuk
Copy link
Contributor

@DenisTarasyuk DenisTarasyuk commented Apr 29, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

What changes are included in this PR?

  1. Added type cast to signed char to save existing x86 behavior on Arm platform.
  2. Added tests cases for negative results.

Are these changes tested?

UT included.

Are there any user-facing changes?

None

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #41433 has been automatically assigned in GitHub to PR creator.

kou
kou approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I think that the behavior of >=128 value is undefined because ASCII defines only 0..127. But this will not be harmful.

@kou kou merged commit 6dc6623 into apache:main Apr 30, 2024
32 of 34 checks passed
@kou kou removed the awaiting review Awaiting review label Apr 30, 2024
@kou kou mentioned this pull request Apr 30, 2024
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 30, 2024
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6dc6623.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them.

@DenisTarasyuk DenisTarasyuk deleted the GH-41433 branch April 30, 2024 13:07
DenisTarasyuk added a commit to DenisTarasyuk/arrow that referenced this pull request Apr 30, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
4297436 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@DenisTarasyuk DenisTarasyuk mentioned this pull request Apr 30, 2024
Merged
DenisTarasyuk added a commit to DenisTarasyuk/arrow that referenced this pull request May 2, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
b0e9720 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
@DenisTarasyuk @tolleybot
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
490176e 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk added a commit to dremio/arrow that referenced this pull request May 3, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
ae1df93 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
@DenisTarasyuk @vibhatha
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
fe2ac00 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@jonkeane jonkeane mentioned this pull request Jun 20, 2024
Closed
lriggs pushed a commit to lriggs/arrow that referenced this pull request Sep 6, 2024
@DenisTarasyuk @lriggs
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
9aa5992 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk added a commit to DenisTarasyuk/arrow that referenced this pull request Sep 30, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
d6f6fe6 
… result on x86 and Arm (apache#41434)

### Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

### What changes are included in this PR?

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

### Are these changes tested?
UT included.

### Are there any user-facing changes?
None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@DenisTarasyuk DenisTarasyuk mentioned this pull request Sep 30, 2024
Merged
DenisTarasyuk added a commit to DenisTarasyuk/arrow that referenced this pull request Oct 2, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
5ec7493 
… result on x86 and Arm (apache#41434)

Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

UT included.

None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk added a commit to dremio/arrow that referenced this pull request Oct 4, 2024
@DenisTarasyuk
apacheGH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same…
67a7751 
… result on x86 and Arm (apache#41434)

Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.

1. Added type cast to signed char to save existing x86 behavior on Arm platform.
2. Added tests cases for negative results.

UT included.

None

* GitHub Issue: apache#41433

Authored-by: DenisTarasyuk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++ Component: Gandiva
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisTarasyuk @kou