-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41164: [C#] Fix concatenation of sliced arrays #41245
Conversation
|
|
||
namespace Apache.Arrow.Tests | ||
{ | ||
static class ArrayArrayBuilderFactoryReflector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was originally added as a way to access the internal ArrowArrayBuilderFactory
class, but since it was added, an InternalsVisibleTo("Apache.Arrow.Tests")
assembly attribute has been added to Apache.Arrow
, so this is no longer needed.
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 63c91ff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Can this be backported to a bugfix |
Rationale for this change
Makes array concatenation work correctly when the input arrays have been sliced.
What changes are included in this PR?
TestDataGenerator
can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a newGenerateTestData<TArray, TArrayBuilder>
method that works with builders that are notIArrowArrayBuilder<T, TArray, TArrayBuilder>
, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic inGenerateTestData
.ArrayDataConcatenator
logic to handle sliced input arraysAre these changes tested?
Yes, I've added a new test for this.
Are there any user-facing changes?
Yes, this is a user-facing bug fix.