GH-41238: [Release] Use UTF-8 as the default encoding to upload binary #41242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… binary We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters.
|
|
github-actions
bot
added
awaiting merge
|
I used this for 16.0.0 RC0 and confirmed that UTF-8 is used by debug print. |
felipecrv
reviewed
Apr 17, 2024
Comment on lines
+25
to
+34
| export LC_ADDRESS=C.UTF-8 | ||
| export LC_CTYPE=C.UTF-8 | ||
| export LC_IDENTIFICATION=C.UTF-8 | ||
| export LC_MEASUREMENT=C.UTF-8 | ||
| export LC_MONETARY=C.UTF-8 | ||
| export LC_NAME=C.UTF-8 | ||
| export LC_NUMERIC=C.UTF-8 | ||
| export LC_PAPER=C.UTF-8 | ||
| export LC_TELEPHONE=C.UTF-8 | ||
| export LC_TIME=C.UTF-8 |
There was a problem hiding this comment.
You could set LC_ALL=C.UTF-8
There was a problem hiding this comment.
Ah, I misunderstood LC_ALL. I thought it can be overwritten by other LC_* like LANG.
I'll simplify the code. Thanks.
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d49b62d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
Apr 29, 2024
#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: #41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
… binary (apache#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: apache#41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 4, 2024
… binary (apache#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: apache#41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
… binary (apache#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: apache#41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
… binary (apache#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: apache#41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
… binary (apache#41242) ### Rationale for this change We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters. ### What changes are included in this PR? Use `LANG=C.UTF-8` and `LC_*=C.UTF-8` to use UTF-8 as the default encoding. ### Are these changes tested? Yes. I used this for 16.0.0 RC0. ### Are there any user-facing changes? No. * GitHub Issue: apache#41238 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters.
What changes are included in this PR?
Use
LANG=C.UTF-8andLC_*=C.UTF-8to use UTF-8 as the default encoding.Are these changes tested?
Yes. I used this for 16.0.0 RC0.
Are there any user-facing changes?
No.
ArgumentError: invalid byte sequence in US-ASCIIwhen signing binaries for RC0 #41238