-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41098: [Python] Add copy keyword in Array.__array__ for numpy 2.0+ compatibility #41071
Merged
pitrou
merged 8 commits into
apache:main
from
jorisvandenbossche:gh-39532-numpy-compat-array
Apr 15, 2024
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2f1b8cc
GH-39532: [Python] Add copy keyword in Array.__array__ for numpy 2.0+…
jorisvandenbossche 686865e
properly handle the case of copy=False
jorisvandenbossche 2bd63a9
raise error for copy=False in ChunkedArray/RecordBatch/Table
jorisvandenbossche 5b87fd3
Merge remote-tracking branch 'upstream/main' into gh-39532-numpy-comp…
jorisvandenbossche 0e2b402
add support for copy=True as well
jorisvandenbossche 4e2bc7d
remove TODO comment
jorisvandenbossche d980cef
fix to actually use is_numeric
jorisvandenbossche 4b630f6
Merge remote-tracking branch 'upstream/main' into gh-39532-numpy-comp…
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this make a second copy for e.g. boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, boolean is not considered as primitive (although you might expect that). So a boolean array takes the code path below just returning the numpy
values
is no dtype was required, so no second copy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sorry, boolean is of course "primitive", what I meant to say is that it is not "numeric", and the code above was meant to use
is_numeric
(I added that to libarrow.pxd for that purpose). Good catch ..