-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Docs][Java] Fix wrong method usage in example #40940
Conversation
Couldn't find get method
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR. LGTM!
@github-actions crossbow submit preview-docs |
Revision: 5151b23 Submitted crossbow builds: ursacomputing/crossbow @ actions-effb5b3ff9
|
er, yes, the PR title needs to change as a basic requirement - that goes without saying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I've updated the title and description.
Agreed! Unfortunately I don't have the edit title access. Thanks @kou 👍 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 782c52f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change `DictionaryProvider` doesn't have `get` method. ### What changes are included in this PR? It should be `lookup` not `get`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. Authored-by: 野鹿 <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change `DictionaryProvider` doesn't have `get` method. ### What changes are included in this PR? It should be `lookup` not `get`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. Authored-by: 野鹿 <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
DictionaryProvider
doesn't haveget
method.What changes are included in this PR?
It should be
lookup
notget
.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.