Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40843: [Java] Cleanup protobuf-maven-plugin usage #40844

Merged
merged 2 commits into from
Mar 28, 2024
Merged

GH-40843: [Java] Cleanup protobuf-maven-plugin usage #40844

merged 2 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. apacheGH-40843: [Java] Cleanup protobuf-maven-plugin usage 

    * Add protobuf-maven-plugin plugin to top level pom.xml under
  pluginManagement to define version and common configuration for all
  modules
* Remove unnecessary executions of test-compile goal when no test
  protobufs are present
* Remove use of outputDirectory and clearOutputDirectory and let the plugin
  choose it for each execution (the default output directory is based on
  the phase (main vs test) and the language/plugin-id)
* Replace use of compile/compile-custom goals with
  test-compile/test-compile-custom when generating test protobufs
    @laurentgo
    laurentgo committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a1b7651 View commit details
    Browse the repository at this point in the history

  2. Fix gandiva/pom.xml

    @laurentgo
    laurentgo committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7379a31 View commit details
    Browse the repository at this point in the history