MINOR: [C++][Azure][FS] Document some limitations and atomicity guarantees #40838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
Tom-Newton
approved these changes
Mar 27, 2024
Comment on lines
+287
to
+288
| /// accounts. A check is made to guarantee the parent directory doesn't | ||
| /// disappear after the blob is deleted and while this operation is running, |
There was a problem hiding this comment.
Is this referring to flat namespace accounts only? I can't imagine a hierarchical namespace directory disappearing when a file is deleted.
There was a problem hiding this comment.
Re-wording suggestion? My intention is being concise, but yeah, none of this applies to HNS accounts.
There was a problem hiding this comment.
Less concise but I would go for
Suggested change
| /// accounts. A check is made to guarantee the parent directory doesn't | |
| /// disappear after the blob is deleted and while this operation is running, | |
| /// accounts. On flat namespace storage accounts a check is made to guarantee the parent directory doesn't | |
| /// disappear after the blob is deleted and while this operation is running, |
I don't feel strongly
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit edf7e57. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…ntees (apache#40838) ### Rationale for this change Documenting some details of the behavior of destructive filesystem operations. ### What changes are included in this PR? Only docstring changes. ### Are these changes tested? N/A. Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…ntees (apache#40838) ### Rationale for this change Documenting some details of the behavior of destructive filesystem operations. ### What changes are included in this PR? Only docstring changes. ### Are these changes tested? N/A. Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Documenting some details of the behavior of destructive filesystem operations.
What changes are included in this PR?
Only docstring changes.
Are these changes tested?
N/A.