Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40619: [Java] JDBC Adapter Build Issue #40656

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

vibhatha
Copy link
Collaborator

@vibhatha vibhatha commented Mar 19, 2024

Rationale for this change

Compiling JDBC Adapter module fails when running from a time zone which is not UTC. The tests assume the set time zone is UTC. Since running from a location where the timezone is not UTC, the error documented in #40619 occurs.

What changes are included in this PR?

Adding the time zone as a property to maven profile.

Are these changes tested?

These changes have been tested locally in a non-UTC timezone (+0530).

Are there any user-facing changes?

No

@vibhatha
Copy link
Collaborator Author

@github-actions crossbow submit verify-rc-source-java-linux-almalinux-8-amd64

@vibhatha
Copy link
Collaborator Author

@github-actions crossbow submit java

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 19, 2024
@vibhatha
Copy link
Collaborator Author

@github-actions crossbow submit verify-rc-source-java

@vibhatha vibhatha requested a review from kou March 19, 2024 00:30
Copy link

Unable to match any tasks for `java`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8335583341

Copy link

Revision: a71a75e

Submitted crossbow builds: ursacomputing/crossbow @ actions-da05b0cde8

Task Status
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions

Copy link

Revision: a71a75e

Submitted crossbow builds: ursacomputing/crossbow @ actions-0be4c494fc

Task Status
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha
Copy link
Collaborator Author

@github-actions crossbow submit java

Copy link

Revision: a71a75e

Submitted crossbow builds: ursacomputing/crossbow @ actions-e0930787da

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha
Copy link
Collaborator Author

It seems like this PR is not breaking any CIs.
Except for the known and documented issues:

  1. Issue in CI -> Documented
  2. Issue in CI -> Documented

@vibhatha vibhatha marked this pull request as ready for review March 19, 2024 02:01
@vibhatha vibhatha requested a review from lidavidm as a code owner March 19, 2024 02:01
@vibhatha vibhatha marked this pull request as draft March 19, 2024 02:01
@vibhatha
Copy link
Collaborator Author

Probably better to wait until the issues which are unrelated to this modification though validates it.

@vibhatha
Copy link
Collaborator Author

@github-actions crossbow submit -g java

Copy link

Revision: 27ec5dc

Submitted crossbow builds: ursacomputing/crossbow @ actions-80ff4b4599

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha vibhatha marked this pull request as ready for review March 19, 2024 23:30
@vibhatha vibhatha changed the title [Java] JDBC Adapter Build Issue GH-40619: [Java] JDBC Adapter Build Issue Mar 19, 2024
Copy link

⚠️ GitHub issue #40619 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm merged commit b8e5b51 into apache:main Mar 20, 2024
17 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Mar 20, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 20, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b8e5b51.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants