-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux #40520
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit java-jars |
Revision: 090275e Submitted crossbow builds: ursacomputing/crossbow @ actions-7ff12b2218
|
|
@github-actions crossbow submit java-jars |
Revision: 090275e Submitted crossbow builds: ursacomputing/crossbow @ actions-e8a43da78d
|
seems like |
@github-actions crossbow submit java-jars |
Revision: 803932a Submitted crossbow builds: ursacomputing/crossbow @ actions-cf41726ea3
|
@github-actions crossbow submit java-jars |
Revision: b9fb4f2 Submitted crossbow builds: ursacomputing/crossbow @ actions-2164940a0a
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
Locally I have the following nm --version
GNU nm (GNU Binutils) 2.40
Copyright (C) 2023 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty. but in the CI we have nm: just-symbols: invalid output format
GNU nm version 2.35-5.el7.4
Copyright (C) 2020 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty. Would it be possible to upgrade the cc @raulcd |
If we run |
I see, it seems a bit complicated approach to update nm. Then should we target on more work on Python rather than nm update? |
Yes. Could you try the approach? |
@kou I will try this. |
af29920
to
ccb5841
Compare
@github-actions crossbow submit java-jars |
@github-actions crossbow submit -g java |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@kou, I just checked with the https://repo1.maven.org/maven2/org/apache/arrow/arrow-dataset/15.0.2/arrow-dataset-15.0.2.jar Error: Undefined symbols found in /home/vibhatha/Documents/Work/Apache_Arrow/issues/gh-40018/arrow-dataset-15.0.2/x86_64/libarrow_dataset_jni.so:
EVP_MD_CTX_create
EVP_MD_CTX_destroy
HMAC_CTX_cleanup
HMAC_CTX_init This PR fixes the protobuf issue, but it seems like we still do have openssl related stuff here, which is not in the allowed list right? |
7a0e3b7
to
06601f4
Compare
@pitrou appreciate your feedback for this PR. |
Rationale for this change
This PR includes a check to find out if there are undefined symbols associated with the libraries.
What changes are included in this PR?
Includes a util functions which uses
nm
andldconfig
tools to find out libraries and their symbols and determineif there are undefined symbols excluding the symbols in the allowed dependencies.
Are these changes tested?
Locally tested with a faulty shared library, but this needs validation on versions as there is a version mismatch in the local libraries.
Are there any user-facing changes?
No