GH-40366: [C++] Remove const qualifier from Buffer::mutable_span_as #40367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit -g cpp |
|
Revision: 58b3bf6 Submitted crossbow builds: ursacomputing/crossbow @ actions-67a429d9a4
|
bkietz
approved these changes
Mar 5, 2024
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit ee1a8c3. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Mar 7, 2024
…n_as (apache#40367) ### Rationale for this change The const qualifier on `Buffer:mutable_span_as` prevents it from calling the non-const `Buffer::mutable_data_as` ### What changes are included in this PR? See issue title ### Are these changes tested? No, I believe this is a simple oversight ### Are there any user-facing changes? Yes, `Buffer::mutable_span_as` loses it's const qualifier * GitHub Issue: apache#40366 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…n_as (apache#40367) ### Rationale for this change The const qualifier on `Buffer:mutable_span_as` prevents it from calling the non-const `Buffer::mutable_data_as` ### What changes are included in this PR? See issue title ### Are these changes tested? No, I believe this is a simple oversight ### Are there any user-facing changes? Yes, `Buffer::mutable_span_as` loses it's const qualifier * GitHub Issue: apache#40366 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The const qualifier on
Buffer:mutable_span_asprevents it from calling the non-constBuffer::mutable_data_asWhat changes are included in this PR?
See issue title
Are these changes tested?
No, I believe this is a simple oversight
Are there any user-facing changes?
Yes,
Buffer::mutable_span_asloses it's const qualifier