MINOR: [Dev][Archery] Reinstate version constraint on setuptools_scm for comment bot #40162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t bot The comment bot depends on an internal setuptools_scm API that was changed in setuptools_scm 8. See example failure at https://github.com/apache/arrow/actions/runs/7976567301/job/21777437575
pitrou
changed the title
|
I'll merge as soon as CI is green, so as to (hopefully) make the comment bot working again. |
|
Thanks for fixing the fallout here! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0988933. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…for comment bot (apache#40162) The comment bot depends on an internal setuptools_scm API that was changed in setuptools_scm 8. We therefore need to reinstate the Archery version constraint that was removed in apache#40150 See example failure at https://github.com/apache/arrow/actions/runs/7976567301/job/21777437575 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…for comment bot (apache#40162) The comment bot depends on an internal setuptools_scm API that was changed in setuptools_scm 8. We therefore need to reinstate the Archery version constraint that was removed in apache#40150 See example failure at https://github.com/apache/arrow/actions/runs/7976567301/job/21777437575 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment bot depends on an internal setuptools_scm API that was changed in setuptools_scm 8.
We therefore need to reinstate the Archery version constraint that was removed in #40150
See example failure at https://github.com/apache/arrow/actions/runs/7976567301/job/21777437575