Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39982: [Java] Add RunEndEncodedVector #39981

Closed
wants to merge 1 commit into from

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Feb 7, 2024

WIP

Rationale for this change

Add REE vectors to the Java implementation as per the Arrow spec.

What changes are included in this PR?

WIP

Are these changes tested?

WIP

Are there any user-facing changes?

Yes, additional features are added.

@danepitkin danepitkin requested a review from lidavidm as a code owner February 7, 2024 17:12
@danepitkin danepitkin marked this pull request as draft February 7, 2024 17:12
Copy link

github-actions bot commented Feb 7, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@danepitkin danepitkin changed the title WIP: [Java] Run-end Encoded (REE) Vectors (WIP) GH-39982: [Java] Run-end Encoded (REE) Vectors Feb 7, 2024
@danepitkin danepitkin changed the title (WIP) GH-39982: [Java] Run-end Encoded (REE) Vectors (WIP) GH-39982: [Java] Add RunEndEncodedVector Feb 7, 2024
@felipecrv
Copy link
Contributor

@danepitkin Ping me when you need a review.

@danepitkin danepitkin changed the title (WIP) GH-39982: [Java] Add RunEndEncodedVector GH-39982: [Java] Add RunEndEncodedVector Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

⚠️ GitHub issue #39982 has been automatically assigned in GitHub to PR creator.

@ViggoC
Copy link
Contributor

ViggoC commented May 22, 2024

Hi, @danepitkin I am really looking forward to this feature. Is this PR ready to be reviewed?

@danepitkin
Copy link
Member Author

Hi @ViggoC , no this has been paused on my end for quite some time. I might be able to work on it for the Arrow v18 release. Feel free to take it over if needed earlier!

@ViggoC
Copy link
Contributor

ViggoC commented Jun 7, 2024

@danepitkin I can do that, but I have no idea how to add a new vector. Would you point me to some reading material, or just left some TODO comment to show me which part need to be implemented.

@felipecrv
Copy link
Contributor

@danepitkin I can do that, but I have no idea how to add a new vector. Would you point me to some reading material, or just left some TODO comment to show me which part need to be implemented.

Take a look at @vibhatha PRs and find the PRs where he is adding support for StringView to the Java implementation.

@ViggoC
Copy link
Contributor

ViggoC commented Jun 7, 2024

@felipecrv thanks for your info.

@danepitkin
Copy link
Member Author

Potentially superceded by #43888

@danepitkin danepitkin closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants