GH-39651: [Python] Basic pyarrow bindings for Binary/StringView classes #39652
Conversation
|
|
github-actions
bot
added
Component: Python
Component: Documentation
awaiting committer review
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting merge
| cdef class StringViewArray(Array): | ||
| """ | ||
| Concrete class for Arrow arrays of string (or utf8) view data type. | ||
| """ |
There was a problem hiding this comment.
Is it worth adding TODOs or linking future GH issues?
There was a problem hiding this comment.
It's unclear if we need to add any specific method here (at least it's not needed for the current TODO items in the parent issue), so going to leave this as is for now.
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 787afa1. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
@jorisvandenbossche It seems that AppVeyor started failing by this commit. Could you take a look at this? |
|
Ah I assumed it was an unrelated failure .. Indeed seems to have started with this PR, but not directly any idea what could cause this |
… classes (apache#39652) ### Rationale for this change First step for apache#39633: exposing the Array, DataType and Scalar classes for BinaryView and StringView, such that those can already be represented in pyarrow. (I exposed a variant of StringBuilder as well, just for now to be able to create test data) * Closes: apache#39651 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
… classes (apache#39652) ### Rationale for this change First step for apache#39633: exposing the Array, DataType and Scalar classes for BinaryView and StringView, such that those can already be represented in pyarrow. (I exposed a variant of StringBuilder as well, just for now to be able to create test data) * Closes: apache#39651 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
… classes (apache#39652) ### Rationale for this change First step for apache#39633: exposing the Array, DataType and Scalar classes for BinaryView and StringView, such that those can already be represented in pyarrow. (I exposed a variant of StringBuilder as well, just for now to be able to create test data) * Closes: apache#39651 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Rationale for this change
First step for #39633: exposing the Array, DataType and Scalar classes for BinaryView and StringView, such that those can already be represented in pyarrow.
(I exposed a variant of StringBuilder as well, just for now to be able to create test data)