-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release #39622
Conversation
The standard tests are all passing so I think at this point I need a review from someone who knows how this works 😅 |
@github-actions crossbow submit -g vcpkg |
@github-actions crossbow submit -g wheel |
Revision: df9d5a2 Submitted crossbow builds: ursacomputing/crossbow @ actions-e1c32d09f5
|
Revision: df9d5a2 Submitted crossbow builds: ursacomputing/crossbow @ actions-5775383cc3 |
Thanks for launching all the tests. I will investigate the failures |
Summary of failures: Linux ARM builds 1 flake 2 of the mac OS builds |
The macOS failures are known issues being worked on here: #39562 |
For the linux ARM failures could you try this:
Basically setting the required environment variable before installing vcpkg instead of after as we are already doing so. |
@github-actions crossbow submit -g wheel |
|
😞 It appears greater than contributor status is required. |
@github-actions crossbow submit -g wheel |
Revision: c10f601 Submitted crossbow builds: ursacomputing/crossbow @ actions-a18c25bf37 |
I just pushed another commit to use the very latest version of vcpkg. My hope is that this will fix the windows build. (#39622 (comment) is without this update) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-windows-* |
Revision: 3e3bb83 Submitted crossbow builds: ursacomputing/crossbow @ actions-6216612a43
|
Looks like we are getting the same failures on the windows builds so will need to investigate further. Additionally the 2024-01-11 release seems to have broken the java manylinux build in the normal CI. The was working on the 2023-11-20 release so its quite tempting to go back to that. |
I managed to get the windows docker build working locally. The abseil build error is
I don't know what implications are for upgrading visual studio but I will give it a try. It also seems like windows build is broken on
Checking some of these URLs in a browser they all seem to variants of not found errors. |
8ea60d1
to
7ce22d2
Compare
@github-actions crossbow submit wheel-windows-cp312-amd64 |
Revision: 7ce22d2 Submitted crossbow builds: ursacomputing/crossbow @ actions-776e952a91
|
@github-actions crossbow submit java-jars |
Revision: 8764067 Submitted crossbow builds: ursacomputing/crossbow @ actions-a21ab902a6
|
@kou please could you re-trigger archery builds. It looks like the most recent run succeeded apart from one which failed with a timeout reading from the cache https://github.com/ursacomputing/crossbow/actions/runs/7777712547/job/21206359154 |
Done! (Re-ran) |
@github-actions crossbow submit -g wheel |
Revision: 8764067 Submitted crossbow builds: ursacomputing/crossbow @ actions-5e4cec918f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the effort @Tom-Newton !
Just a minor nit but if the latest jobs are successful I think this is ready to get merged. Unless @kou has any other comment.
The |
Co-authored-by: Raúl Cumplido <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1552510. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…pache#39622) ### Rationale for this change Old version of vcpkg is blocking apache#39352 ### What changes are included in this PR? - Upgrade vcpkg - Fix ports patches - Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. - Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. - Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. - Update image used for python wheel builds on windows to 2024-02-05 ### Are these changes tested? Does not change any behaviour so should be covered by existing tests ### Are there any user-facing changes? There shouldn't be * Closes: apache#39621 Lead-authored-by: Thomas Newton <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…pache#39622) ### Rationale for this change Old version of vcpkg is blocking apache#39352 ### What changes are included in this PR? - Upgrade vcpkg - Fix ports patches - Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. - Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. - Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. - Update image used for python wheel builds on windows to 2024-02-05 ### Are these changes tested? Does not change any behaviour so should be covered by existing tests ### Are there any user-facing changes? There shouldn't be * Closes: apache#39621 Lead-authored-by: Thomas Newton <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…pache#39622) ### Rationale for this change Old version of vcpkg is blocking apache#39352 ### What changes are included in this PR? - Upgrade vcpkg - Fix ports patches - Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. - Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. - Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. - Update image used for python wheel builds on windows to 2024-02-05 ### Are these changes tested? Does not change any behaviour so should be covered by existing tests ### Are there any user-facing changes? There shouldn't be * Closes: apache#39621 Lead-authored-by: Thomas Newton <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Old version of vcpkg is blocking #39352
What changes are included in this PR?
abseil
build.VCPKG_FORCE_SYSTEM_BINARIES
to be set before vcpkg install to fix vcpkg install on linux ARM.Are these changes tested?
Does not change any behaviour so should be covered by existing tests
Are there any user-facing changes?
There shouldn't be