MINOR: [R] Default to bundled re2 build #39514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
In my opinion this shouldn't be a MINOR (i.e., make an issue that summarizes the problem we had with CRAN and why this will fix that problem), but I have no problem with its content!
I would also check crossbow submit --group r to make sure it doesn't introduce problems there.
| @@ -26,7 +26,7 @@ add_custom_target(toolchain-tests) | |||
| # Accumulate all bundled targets and we will splice them together later as | |||
| # libarrow_bundled_dependencies.a so that third party libraries have something | |||
| # usable to create statically-linked builds with some BUNDLED dependencies, | |||
| # including allocators like jemalloc and mimalloc | |||
| # including allocators like jllemalloc and mimalloc | |||
There was a problem hiding this comment.
oh no that's probably a rebase mix up, I'll remove it.
github-actions
bot
added
awaiting merge
|
crossbow submit --group r |
|
@github-actions crossbow submit --group r |
|
Revision: d3044bf Submitted crossbow builds: ursacomputing/crossbow @ actions-c0b42ace6a
|
|
The failures are due to #39518 |
|
I have added some more details and reasoning to the description/commit message for future me ^^ |
This reverts commit 825956b.
raulcd
pushed a commit
that referenced
this pull request
Jan 9, 2024
### Rationale for this change The CRAN check on `fedora clang devel` builds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version. A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via `EXTRA_CMAKE_FLAGS`. ### What changes are included in this PR? Default to use our bundled build to prevent the problems. ### Are these changes tested? On a local dev container replicating the cran env. ### Are there any user-facing changes? Source build now default to use the bundled re2 version, this can be overridden. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit f60c281. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
assignUser
added a commit
that referenced
this pull request
Jan 9, 2024
### Rationale for this change The CRAN check on `fedora clang devel` builds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version. A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via `EXTRA_CMAKE_FLAGS`. ### What changes are included in this PR? Default to use our bundled build to prevent the problems. ### Are these changes tested? On a local dev container replicating the cran env. ### Are there any user-facing changes? Source build now default to use the bundled re2 version, this can be overridden. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### Rationale for this change The CRAN check on `fedora clang devel` builds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version. A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via `EXTRA_CMAKE_FLAGS`. ### What changes are included in this PR? Default to use our bundled build to prevent the problems. ### Are these changes tested? On a local dev container replicating the cran env. ### Are there any user-facing changes? Source build now default to use the bundled re2 version, this can be overridden. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The CRAN check on `fedora clang devel` builds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version. A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via `EXTRA_CMAKE_FLAGS`. ### What changes are included in this PR? Default to use our bundled build to prevent the problems. ### Are these changes tested? On a local dev container replicating the cran env. ### Are there any user-facing changes? Source build now default to use the bundled re2 version, this can be overridden. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### Rationale for this change The CRAN check on `fedora clang devel` builds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version. A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via `EXTRA_CMAKE_FLAGS`. ### What changes are included in this PR? Default to use our bundled build to prevent the problems. ### Are these changes tested? On a local dev container replicating the cran env. ### Are there any user-facing changes? Source build now default to use the bundled re2 version, this can be overridden. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The CRAN check on
fedora clang develbuilds with clang against libc++ and has a system re2 installed that was build with C++11 ABI which causes linking to fail due to the [abi:cxx11]-symbol annotation on the system version.A user could manually use the bundled build or path hint a clang version of the library. To avoid extra work for the CRAN maintainers we can just default to the bundled build. The re2 build is small enough that users building from source will not really feel the difference and can still opt to use the system re2 via
EXTRA_CMAKE_FLAGS.What changes are included in this PR?
Default to use our bundled build to prevent the problems.
Are these changes tested?
On a local dev container replicating the cran env.
Are there any user-facing changes?
Source build now default to use the bundled re2 version, this can be overridden.