GH-39225: [GLib] Use Cast() instaed of CastTo #39228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
llama90
force-pushed
the
ARROW-39225
branch
2 times, most recently
from
066f4fc
to
e54044e
Compare
Closed
llama90
force-pushed
the
ARROW-39225
branch
2 times, most recently
from
ba883e5
to
878206b
Compare
kou
reviewed
Jan 2, 2024
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit faa9d80. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Remove legacy code
What changes are included in this PR?
Are these changes tested?
No.
Are there any user-facing changes?
No.