-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39037: [Java] Remove (Contrib/Experimental) mention in Flight SQL #39040
GH-39037: [Java] Remove (Contrib/Experimental) mention in Flight SQL #39040
Conversation
…t SQL Considering that Flight SQL has been present for a while and should be fairly stable, remove the `(Contrib/Experimental)` mention from the pom file which also shows up on Maven Central UI pages
|
We still declare it as experimental in the format itself, though. |
Do we need to go into some formal discussion on the mailiing list first? or is it okay to change the format mention as well? |
Feel free to chime in here: https://lists.apache.org/thread/qoshg8mln3t2ovr90o1yklz4yrpv503h |
cpp/submodules/parquet-testing
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops seems we shouldn't edit parquet-testing
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, was not supposed to. Thanks for pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we remove the submodule change
@lidavidm Would you prefer I also take care of the rest of the mentions, following up on the vote on the mailing list? |
up to you, I already filed a new issue for that so don't feel like you have to here |
Also took a look and LGTM. |
Ok, will keep my change as-is then. Thanks |
A CI is failing, but it seems unrelated. |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a4fae02. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…t SQL (apache#39040) ### Rationale for this change Considering that Flight SQL has been present for a while and should be fairly stable, remove the `(Contrib/Experimental)` mention from the pom file which also shows up on Maven Central UI pages ### Are these changes tested? Local test but there's no code change, only cosmetic ### Are there any user-facing changes? None * Closes: apache#39037 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
…t SQL (apache#39040) ### Rationale for this change Considering that Flight SQL has been present for a while and should be fairly stable, remove the `(Contrib/Experimental)` mention from the pom file which also shows up on Maven Central UI pages ### Are these changes tested? Local test but there's no code change, only cosmetic ### Are there any user-facing changes? None * Closes: apache#39037 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
Rationale for this change
Considering that Flight SQL has been present for a while and should be fairly stable, remove the
(Contrib/Experimental)
mention from the pom file which also shows up on Maven Central UI pagesAre these changes tested?
Local test but there's no code change, only cosmetic
Are there any user-facing changes?
None