Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39037: [Java] Remove (Contrib/Experimental) mention in Flight SQL #39040

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

laurentgo
Copy link
Collaborator

@laurentgo laurentgo commented Dec 1, 2023

Rationale for this change

Considering that Flight SQL has been present for a while and should be fairly stable, remove the (Contrib/Experimental) mention from the pom file which also shows up on Maven Central UI pages

Are these changes tested?

Local test but there's no code change, only cosmetic

Are there any user-facing changes?

None

…t SQL

Considering that Flight SQL has been present for a while and should be
fairly stable, remove the `(Contrib/Experimental)` mention from the pom
file which also shows up on Maven Central UI pages
@laurentgo laurentgo requested a review from lidavidm as a code owner December 1, 2023 18:33
Copy link

github-actions bot commented Dec 1, 2023

⚠️ GitHub issue #39037 has been automatically assigned in GitHub to PR creator.

@lidavidm
Copy link
Member

lidavidm commented Dec 1, 2023

We still declare it as experimental in the format itself, though.

@laurentgo
Copy link
Collaborator Author

Do we need to go into some formal discussion on the mailiing list first? or is it okay to change the format mention as well?

@lidavidm
Copy link
Member

lidavidm commented Dec 6, 2023

Feel free to chime in here: https://lists.apache.org/thread/qoshg8mln3t2ovr90o1yklz4yrpv503h

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops seems we shouldn't edit parquet-testing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, was not supposed to. Thanks for pointing it out

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 11, 2023
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we remove the submodule change

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 12, 2023
@laurentgo
Copy link
Collaborator Author

@lidavidm Would you prefer I also take care of the rest of the mentions, following up on the vote on the mailing list?

@lidavidm
Copy link
Member

up to you, I already filed a new issue for that so don't feel like you have to here

@vibhatha
Copy link
Collaborator

Also took a look and LGTM.

@github-actions github-actions bot added awaiting change review Awaiting change review and removed Component: C++ awaiting changes Awaiting changes labels Dec 13, 2023
@laurentgo
Copy link
Collaborator Author

up to you, I already filed a new issue for that so don't feel like you have to here

Ok, will keep my change as-is then. Thanks

@vibhatha
Copy link
Collaborator

A CI is failing, but it seems unrelated.

@lidavidm lidavidm merged commit a4fae02 into apache:main Dec 14, 2023
14 of 15 checks passed
@lidavidm lidavidm removed the awaiting change review Awaiting change review label Dec 14, 2023
@laurentgo laurentgo deleted the laurentgo/remove-contrib-mention branch December 14, 2023 16:26
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a4fae02.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…t SQL (apache#39040)

### Rationale for this change

Considering that Flight SQL has been present for a while and should be fairly stable, remove the `(Contrib/Experimental)` mention from the pom file which also shows up on Maven Central UI pages

### Are these changes tested?

Local test but there's no code change, only cosmetic

### Are there any user-facing changes?

None

* Closes: apache#39037

Authored-by: Laurent Goujon <[email protected]>
Signed-off-by: David Li <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…t SQL (apache#39040)

### Rationale for this change

Considering that Flight SQL has been present for a while and should be fairly stable, remove the `(Contrib/Experimental)` mention from the pom file which also shows up on Maven Central UI pages

### Are these changes tested?

Local test but there's no code change, only cosmetic

### Are there any user-facing changes?

None

* Closes: apache#39037

Authored-by: Laurent Goujon <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Remove Contrib/Experimental from Flight SQL
4 participants