Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38958: [C++][Parquet] Fix spelling #38959

Merged
merged 30 commits into from
Dec 5, 2023
Merged

GH-38958: [C++][Parquet] Fix spelling #38959

merged 30 commits into from
Dec 5, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 29, 2023 •
edited by github-actions bot
Loading

Rationale for this change

What changes are included in this PR?

Spelling fixes to parquet

Are these changes tested?

Are there any user-facing changes?

@jsoref
spelling: ancestor
f15d8b1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: anymore
d6fd304 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: bitmap
b88bc9f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: boundaries
d236d09 
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref requested a review from wgtmac as a code owner November 29, 2023 00:59
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #38958 has been automatically assigned in GitHub to PR creator.

wgtmac
wgtmac requested changes Nov 29, 2023
View reviewed changes
cpp/src/generated/parquet_types.cpp Outdated Show resolved Hide resolved
cpp/src/generated/parquet_types.h Outdated Show resolved Hide resolved
@wgtmac wgtmac changed the title GH-38958: [Parquet] Fix spelling GH-38958: [C++][Parquet] Fix spelling Nov 29, 2023
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 29, 2023
@mapleFU
Copy link
Member

mapleFU commented Nov 29, 2023

Rest LGTM

mapleFU
mapleFU approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mapleFU
mapleFU reviewed Dec 3, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch LGTM, just a few naive questions

Will merge it if problem resolve and CI passed

cpp/src/parquet/reader_test.cc Outdated Show resolved Hide resolved
cpp/src/parquet/encoding.h Show resolved Hide resolved
cpp/src/parquet/statistics.h Show resolved Hide resolved
jsoref added 11 commits December 4, 2023 07:33
@jsoref
spelling: boundschecking
6e5e1ca 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cannot
7e579ba 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: coalesced
4302f04 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: column
a0b1756 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: decode
dd73a61 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: decryptor
29360f9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: different
fb8fd1a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: documentation
80563f9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: empties
76e208d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: everything
208c8b3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: exercising
3314140 
Signed-off-by: Josh Soref <[email protected]>
jsoref added 15 commits December 4, 2023 07:33
@jsoref
spelling: extracts
56d1d99 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: fine-grained
06cfd7b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: generate
06f9d99 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: group
ad64841 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: increments
4871c31 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: number
f870d0c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: ordinal
dbe2a5e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: preexisting
5d44129 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: primitive
83044e9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: properly
9aab9f6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: shared
87f39ca 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: the
6e7b6cd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: type
a27897c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unknown
b5cf1a1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: vectors
b41b487 
Signed-off-by: Josh Soref <[email protected]>
@mapleFU
Copy link
Member

mapleFU commented Dec 4, 2023

Will merge it tomorrow night if no other's comment

@mapleFU mapleFU merged commit 6ff2127 into apache:main Dec 5, 2023
31 of 32 checks passed
@mapleFU mapleFU removed the awaiting committer review Awaiting committer review label Dec 5, 2023
@jsoref jsoref deleted the spelling-parquet branch December 5, 2023 14:39
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6ff2127.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@jsoref @dgreiss
apacheGH-38958: [C++][Parquet] Fix spelling (apache#38959)
1f605dd 
### Rationale for this change

### What changes are included in this PR?

Spelling fixes to *parquet*

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38958

Authored-by: Josh Soref <[email protected]>
Signed-off-by: mwish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@wgtmac wgtmac wgtmac approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: Parquet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++][Parquet] Spelling errors identified by check-spelling
3 participants
@jsoref @mapleFU @wgtmac