Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38844: [C++] S3FileSystem export s3 sdk config "use_virtual_addressing" to arrow::fs::S3Options #38858

Merged
merged 7 commits into from
Dec 5, 2023
Merged

GH-38844: [C++] S3FileSystem export s3 sdk config "use_virtual_addressing" to arrow::fs::S3Options #38858

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dbe7f42
[C++][fix] export s3 sdk config "use_virtual_addressing" to arrow::fs…
liangjiawei1110 Nov 23, 2023
2e2cbf1
[fix]
liangjiawei1110 Nov 23, 2023
0d329bb
[fix] change the use virtual hosted logic
liangjiawei1110 Nov 24, 2023
db9e925
[fix] add a more clear comment
liangjiawei1110 Nov 29, 2023
da32fc6
Update cpp/src/arrow/filesystem/s3fs.h
liangjiawei1110 Nov 30, 2023
9c41a06
[fix]
liangjiawei1110 Nov 29, 2023
945eda7
Make docstring more informative
pitrou Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/arrow/filesystem/s3fs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,8 @@ class ClientBuilder {
client_config_.caPath = ToAwsString(internal::global_options.tls_ca_dir_path);
}

const bool use_virtual_addressing = options_.endpoint_override.empty();
const bool use_virtual_addressing =
options_.endpoint_override.empty() || options_.force_virtual_addressing;

// Set proxy options if provided
if (!options_.proxy_options.scheme.empty()) {
Expand Down
6 changes: 6 additions & 0 deletions cpp/src/arrow/filesystem/s3fs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ struct ARROW_EXPORT S3Options {
/// Type of credentials being used. Set along with credentials_provider.
S3CredentialsKind credentials_kind = S3CredentialsKind::Default;

/// Whether to use virtual addressing of buckets
liangjiawei1110 marked this conversation as resolved.
Show resolved Hide resolved
///
/// If true, then virtual addressing is always enabled.
/// If false, then virtual addressing is only enabled if `endpoint_override` is empty.
pitrou marked this conversation as resolved.
Show resolved Hide resolved
bool force_virtual_addressing = false;

/// Whether OutputStream writes will be issued in the background, without blocking.
bool background_writes = true;

Expand Down
Loading