Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38333: [C++][FS][Azure] Implement file writes #38780

Merged
merged 26 commits into from
Nov 21, 2023
Merged

GH-38333: [C++][FS][Azure] Implement file writes #38780

merged 26 commits into from
Nov 21, 2023

Commits on Nov 19, 2023

  1. Paste in object append stream from apache#12914

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    89899b4 View commit details
    Browse the repository at this point in the history

  2. Delete hierarchical namespace code paths

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    12c1978 View commit details
    Browse the repository at this point in the history

  3. Paste in tests from gcsfs_test.cc

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bd787cc View commit details
    Browse the repository at this point in the history

  4. Mostly correct tests

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    cb9879b View commit details
    Browse the repository at this point in the history

  5. Paste in OpenOutputStream and OpenAppendStream from apache#12914

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bbaf138 View commit details
    Browse the repository at this point in the history

  6. Tests pass

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    2f27fbb View commit details
    Browse the repository at this point in the history

  7. Better error handling and tidy

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bfeb57d View commit details
    Browse the repository at this point in the history

  8. Implement append and output

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    d4c53b2 View commit details
    Browse the repository at this point in the history

  9. Fix rebase

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    a1a8c15 View commit details
    Browse the repository at this point in the history

  10. Add tests to distinguish OpenAppendStream and OpenOutputStream

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    0b0a2ee View commit details
    Browse the repository at this point in the history

  11. More precise error handling on calls to Azure blob storage

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    c69f188 View commit details
    Browse the repository at this point in the history

  12. Avoid unnecessary extra block list fetching and committing

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    5a91113 View commit details
    Browse the repository at this point in the history

  13. Adjust block_ids and add some comments

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    1c4300b View commit details
    Browse the repository at this point in the history

  14. Add test for writing blob metadata

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    a62b95e View commit details
    Browse the repository at this point in the history

  15. Implement metadata writes

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    28ec1ed View commit details
    Browse the repository at this point in the history

  16. Add simple sanity checks on the location

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    2800dea View commit details
    Browse the repository at this point in the history

  17. Tidy

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    9a98a0f View commit details
    Browse the repository at this point in the history

  18. PR comments 1

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    d86c374 View commit details
    Browse the repository at this point in the history

  19. PR comments2: move DoAppend to private

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    77f8345 View commit details
    Browse the repository at this point in the history

  20. Autoformat

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    0178660 View commit details
    Browse the repository at this point in the history

  21. Handle TODO(apacheGH-38780) comments for using fs to write data in tests

    @Tom-Newton
    Tom-Newton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    7b19feb View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. PR comments: tests tidy up

    @Tom-Newton
    Tom-Newton committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    74a6d55 View commit details
    Browse the repository at this point in the history

  2. Add a comment about the risk of overlapping block ids

    @Tom-Newton
    Tom-Newton committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9a0d9ca View commit details
    Browse the repository at this point in the history

  3. Lint

    @Tom-Newton
    Tom-Newton committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0e84a82 View commit details
    Browse the repository at this point in the history

  4. Lint

    @Tom-Newton
    Tom-Newton committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ad0ed8f View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Simplify

    @kou
    kou authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    7412b90 View commit details
    Browse the repository at this point in the history