GH-38758: [C++][FS][Azure] Rename AzurePath to AzureLocation #38773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's for readability. AzurePath::path_to_file may be confused.
|
|
|
@Tom-Newton @felipecrv You may want to review this. |
Tom-Newton
approved these changes
Nov 18, 2023
|
I'll merge this for following Azure related work. |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 46c226e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38773) ### Rationale for this change It's for readability. `AzurePath::path_to_file` may refer a directory but its name includes `file`. ### What changes are included in this PR? Rename `AzurePath` to `AzureLocation`: * `AzurePath::path_to_file` -> `AzureLocation::path` * `AzurePath::path_to_file_parts` -> `AzureLocation::path_parts` * `AzurePath::full_path` -> `AzureLocation::all` ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38758 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's for readability.
AzurePath::path_to_filemay refer a directory but its name includesfile.What changes are included in this PR?
Rename
AzurePathtoAzureLocation:AzurePath::path_to_file->AzureLocation::pathAzurePath::path_to_file_parts->AzureLocation::path_partsAzurePath::full_path->AzureLocation::allAre these changes tested?
Yes.
Are there any user-facing changes?
No.
AzurePathtoAzureLocation#38758