Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [JS][Docs] Correct typo in README #38658

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

bmschmidt
Copy link
Contributor

@bmschmidt bmschmidt commented Nov 9, 2023

Rationale for this change

A demo variable is named 'uft8' but should clearly be 'utf8'.

What changes are included in this PR?

Two transpostions of two characters

Are these changes tested?

N/A

Are there any user-facing changes?

No

A demo variable is named 'uft8' but should be 'utf8'.
@kou kou changed the title MINOR: [js] Correct typo in js README MINOR: [JS][Docs] Correct typo in README Nov 9, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@kou kou merged commit 79e328b into apache:main Nov 9, 2023
5 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 9, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 9, 2023
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 79e328b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

A demo variable is named 'uft8' but should clearly be 'utf8'.

### What changes are included in this PR?

Two transpostions of two characters

### Are these changes tested?

N/A

### Are there any user-facing changes?

No

Authored-by: Benjamin Schmidt <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

A demo variable is named 'uft8' but should clearly be 'utf8'.

### What changes are included in this PR?

Two transpostions of two characters

### Are these changes tested?

N/A

### Are there any user-facing changes?

No

Authored-by: Benjamin Schmidt <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants