-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [R] Fix broken link in README.md #38657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Good catch!
Co-authored-by: Sutou Kouhei <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8fcaba7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail. ### What changes are included in this PR? The link was updated. ### Are these changes tested? Not needed (docs only) ### Are there any user-facing changes? No Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail. The link was updated. Not needed (docs only) No Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
@raulcd it look's like this wasn't cherry picked even though it is part of the 14.0.2 milestone. Maybe a bug in archery? |
### Rationale for this change There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail. ### What changes are included in this PR? The link was updated. ### Are these changes tested? Not needed (docs only) ### Are there any user-facing changes? No Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
Only issues are cherry-picked, our scripts to cherry pick don't cover MINOR, we require an issue associated. |
Ah I see, sorry I thought that was handled automatically. I will notify you next time :) |
### Rationale for this change There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail. ### What changes are included in this PR? The link was updated. ### Are these changes tested? Not needed (docs only) ### Are there any user-facing changes? No Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
Rationale for this change
There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.
What changes are included in this PR?
The link was updated.
Are these changes tested?
Not needed (docs only)
Are there any user-facing changes?
No