Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Fix broken link in README.md #38657

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

paleolimbot
Copy link
Member

Rationale for this change

There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.

What changes are included in this PR?

The link was updated.

Are these changes tested?

Not needed (docs only)

Are there any user-facing changes?

No

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

r/README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 9, 2023
Co-authored-by: Sutou Kouhei <[email protected]>
@paleolimbot paleolimbot merged commit 8fcaba7 into apache:main Nov 10, 2023
10 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Nov 10, 2023
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8fcaba7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.

### What changes are included in this PR?

The link was updated.

### Are these changes tested?

Not needed (docs only)

### Are there any user-facing changes?

No

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@assignUser assignUser added this to the 14.0.2 milestone Nov 27, 2023
assignUser pushed a commit to assignUser/arrow that referenced this pull request Dec 1, 2023
There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.

The link was updated.

Not needed (docs only)

No

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@assignUser
Copy link
Member

@raulcd it look's like this wasn't cherry picked even though it is part of the 14.0.2 milestone. Maybe a bug in archery?

assignUser pushed a commit that referenced this pull request Dec 23, 2023
### Rationale for this change

There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.

### What changes are included in this PR?

The link was updated.

### Are these changes tested?

Not needed (docs only)

### Are there any user-facing changes?

No

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@raulcd
Copy link
Member

raulcd commented Dec 23, 2023

Only issues are cherry-picked, our scripts to cherry pick don't cover MINOR, we require an issue associated.
This is something we could try to add but we've never cherry-picked minor issues when a maintenance branch is generated.

@assignUser
Copy link
Member

Ah I see, sorry I thought that was handled automatically. I will notify you next time :)

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

There is a broken link in README.md that refers to an old URL in the Arrow documentation. This causes the CRAN incoming check to fail.

### What changes are included in this PR?

The link was updated.

### Are these changes tested?

Not needed (docs only)

### Are there any user-facing changes?

No

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants