-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38591: [Parquet][C++] Remove redundant open calls in ParquetFileFormat::GetReaderAsync
#38621
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
Will merge in one day if don't have any further comments |
Also cc @raulcd would this better in 14.0.1? |
14.0.1 is frozen and ready to be shipped |
ParquetFileFormat::GetReaderAsync
I labeled the issue as backport-candidate, though, in case we do another bug fix release |
@jorisvandenbossche Maybe this should also related to #38466 and #38437 ? I'll drive them to be merged this week |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e62ec62. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…tFileFormat::GetReaderAsync` (apache#38621) ### Rationale for this change There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432. ### What changes are included in this PR? Remove the extra method calls. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38591 Authored-by: Eero Lihavainen <[email protected]> Signed-off-by: mwish <[email protected]>
…tFileFormat::GetReaderAsync` (apache#38621) ### Rationale for this change There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432. ### What changes are included in this PR? Remove the extra method calls. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38591 Authored-by: Eero Lihavainen <[email protected]> Signed-off-by: mwish <[email protected]>
…ormat::GetReaderAsync` (#38621) ### Rationale for this change There were duplicate method calls causing extra I/O operations, apparently unintentional from 0793432. ### What changes are included in this PR? Remove the extra method calls. ### Are these changes tested? ### Are there any user-facing changes? * Closes: #38591 Authored-by: Eero Lihavainen <[email protected]> Signed-off-by: mwish <[email protected]>
…tFileFormat::GetReaderAsync` (apache#38621) ### Rationale for this change There were duplicate method calls causing extra I/O operations, apparently unintentional from apache@0793432. ### What changes are included in this PR? Remove the extra method calls. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38591 Authored-by: Eero Lihavainen <[email protected]> Signed-off-by: mwish <[email protected]>
Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from 0793432.
What changes are included in this PR?
Remove the extra method calls.
Are these changes tested?
Are there any user-facing changes?