-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38602: [R] Add missing prod
for summarize
#38601
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
prod
for summarize
prod
for summarizeprod
for summarize
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean! Thank you!
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6dcba93. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change `prod` is currently missing for use in summarize. ### What changes are included in this PR? Added `prod` for summarize aggregation. ### Are these changes tested? Yes, included the same tests used for the other aggregation functions for summarize. ### Are there any user-facing changes? Yes, added `prod` function. * Closes: apache#38602 Authored-by: Maximilian Muecke <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
### Rationale for this change `prod` is currently missing for use in summarize. ### What changes are included in this PR? Added `prod` for summarize aggregation. ### Are these changes tested? Yes, included the same tests used for the other aggregation functions for summarize. ### Are there any user-facing changes? Yes, added `prod` function. * Closes: apache#38602 Authored-by: Maximilian Muecke <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
### Rationale for this change `prod` is currently missing for use in summarize. ### What changes are included in this PR? Added `prod` for summarize aggregation. ### Are these changes tested? Yes, included the same tests used for the other aggregation functions for summarize. ### Are there any user-facing changes? Yes, added `prod` function. * Closes: apache#38602 Authored-by: Maximilian Muecke <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
Rationale for this change
prod
is currently missing for use in summarize.What changes are included in this PR?
Added
prod
for summarize aggregation.Are these changes tested?
Yes, included the same tests used for the other aggregation functions for summarize.
Are there any user-facing changes?
Yes, added
prod
function.prod
function for summarize #38602