Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs][C++] Fix a typo #38568

Merged
merged 1 commit into from
Nov 3, 2023
Merged

MINOR: [Docs][C++] Fix a typo #38568

merged 1 commit into from
Nov 3, 2023

Conversation

pmoulon
Copy link
Contributor

@pmoulon pmoulon commented Nov 3, 2023

Rationale for this change

Noticed a typo on the web doc and proposing here a fix

Are these changes tested?

No. But the PR is changing only text.

Are there any user-facing changes?

Yes. But only documentation typo

Copy link

github-actions bot commented Nov 3, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pmoulon pmoulon changed the title Typo fix in documentation MINOR: [Documentation] Typo fix Nov 3, 2023
@kou kou changed the title MINOR: [Documentation] Typo fix MINOR: [Docs][C++] Fix a typo Nov 3, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@kou kou merged commit d4deb36 into apache:main Nov 3, 2023
5 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 3, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 3, 2023
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d4deb36.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@pmoulon pmoulon deleted the typo_fix branch November 4, 2023 00:42
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

Noticed a typo on the web doc and proposing here a fix

### Are these changes tested?

No. But the PR is changing only text.

### Are there any user-facing changes?

Yes. But only documentation typo

Authored-by: Pierre Moulon <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Noticed a typo on the web doc and proposing here a fix

### Are these changes tested?

No. But the PR is changing only text.

### Are there any user-facing changes?

Yes. But only documentation typo

Authored-by: Pierre Moulon <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants