Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38417: [MATLAB] Implement a TableTypeValidator class that validates a MATLAB cell array contains only tables that share the same schema #38551

Merged
merged 21 commits into from
Nov 2, 2023
Merged

GH-38417: [MATLAB] Implement a TableTypeValidator class that validates a MATLAB cell array contains only tables that share the same schema #38551

merged 21 commits into from
Nov 2, 2023

Commits on Oct 31, 2023

  1. Modify arrow.array.internal.list.Validator to inherit from matlab.mix… 

    …in.Heterogeneous
    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    86e34e7 View commit details
    Browse the repository at this point in the history

  2. Add stub class arrow.array.internal.list.TableValidator

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4f94d07 View commit details
    Browse the repository at this point in the history

  3. Add arrow.array.internal.list.createValidator gateway function

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    fa48833 View commit details
    Browse the repository at this point in the history

  4. Fix typo in createValidator

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d022540 View commit details
    Browse the repository at this point in the history

  5. Add stub implementations for TableValidator's methods

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d82a125 View commit details
    Browse the repository at this point in the history

  6. 1. Fix typo in TableValidator constructor 

    2. Implement getElementLength in TableValidator to return the height of
   the table
    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d5e18be View commit details
    Browse the repository at this point in the history

  7. Implement TableValidator's reshapeCellElements method

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6bba319 View commit details
    Browse the repository at this point in the history

  8. Implement TableValidator's getElementLength method

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3f59911 View commit details
    Browse the repository at this point in the history

  9. Implement TableValidator's validateElement method

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    eeb6f14 View commit details
    Browse the repository at this point in the history

  10. Fix bug in validateElement

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c3084d8 View commit details
    Browse the repository at this point in the history

  11. Update comments

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    53af478 View commit details
    Browse the repository at this point in the history

  12. Add test file for arrow.array.internal.list.createValidator

    @sgilmore10
    sgilmore10 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ee3e3bd View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Add comments to test cases in tCreateValidator.m

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bdee207 View commit details
    Browse the repository at this point in the history

  2. Add initial tests for TableValidator

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    52bc3d8 View commit details
    Browse the repository at this point in the history

  3. Add more tests for TableValidator

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c186533 View commit details
    Browse the repository at this point in the history

  4. Update error messages

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7d55cee View commit details
    Browse the repository at this point in the history

  5. Fix iscolumn or isempty condition in validateElement

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    030318b View commit details
    Browse the repository at this point in the history

  6. Add tests for getElementLength and reshapeCellElements

    @sgilmore10
    sgilmore10 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d610d0e View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Remove unnecessary {} in arguments block

    @sgilmore10
    sgilmore10 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b7f49f8 View commit details
    Browse the repository at this point in the history

  2. Update error messages in TableValidator

    @sgilmore10
    sgilmore10 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f3b1062 View commit details
    Browse the repository at this point in the history

  3. Update tTableValidator.m based on code review feedback

    @sgilmore10
    sgilmore10 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3442111 View commit details
    Browse the repository at this point in the history