Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38516: [Go][Parquet] Increment the number of rows written when appending a new row group #38517

Merged
merged 1 commit into from
Nov 13, 2023
Merged

GH-38516: [Go][Parquet] Increment the number of rows written when appending a new row group #38517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/parquet/file/file_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ func (fw *Writer) AppendRowGroup() SerialRowGroupWriter {

func (fw *Writer) appendRowGroup(buffered bool) *rowGroupWriter {
if fw.rowGroupWriter != nil {
fw.nrows += fw.rowGroupWriter.nrows
fw.rowGroupWriter.Close()
}
fw.rowGroups++
Expand Down
2 changes: 2 additions & 0 deletions go/parquet/file/file_writer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ func (t *SerializeTestSuite) fileSerializeTest(codec compress.Compression, expec
writer.Close()

nrows := t.numRowGroups * t.rowsPerRG
t.EqualValues(nrows, writer.NumRows())

reader, err := file.NewParquetReader(bytes.NewReader(sink.Bytes()))
t.NoError(err)
t.Equal(t.numCols, reader.MetaData().Schema.NumColumns())
Expand Down
Loading